[881] in Kerberos_V5_Development
Re: CVS report: src/lib/krb5/keytab/file ChangeLog ktf_util.c
daemon@ATHENA.MIT.EDU (John Gilmore)
Wed Mar 1 23:33:31 1995
To: krbdev@MIT.EDU
In-Reply-To: Your message of "Wed, 01 Mar 1995 19:39:54 +0500."
Date: Wed, 01 Mar 1995 20:33:24 -0800
From: John Gilmore <gnu@cygnus.com>
Keith, I noticed you introduced NEED_WINSOCK_H into krb5.h.
Can you change this to NEED_SOCKETS? WINSOCK is Windows-specific.
Sockets are a generic interface (originally for Unix).
The reason I did it with a #define before including a generic include
file (in K4) is that it removes the `knowledge' of what include file
names contain socket information, into a single place in the source
tree. Right now in various K5 source files there's a mess of #ifdef
USE_SOCKET_H crap that should be ripped out and put into a single place
(under #ifdef NEED_SOCKETS).
Also note that k5-int.h includes krb5.h. They should never both
be included.
In fact, krb5.h should eventually just include externally visible
definitions for user programs that call krb5. Look at the K4 Windows
distribution and see how many include files get dragged along with
the binary release, because there was no simple "krb.h" that handled
just the set of published interfaces. I hope to fix this for K5.
This means that the code for handling #define NEED_SOCKETS should
not be in krb5.h; it should be in k5-int.h, since the NEED_SOCKETS
stuff is just internal to the Kerberos implementation and is not
part of its documented interface.
If any of this isn't clear, please let me know.
John
