[19071] in Kerberos_V5_Development
Re: Questions about iter check in profile_iterator()
daemon@ATHENA.MIT.EDU (Greg Hudson)
Tue Jan 13 12:04:26 2015
Message-ID: <54B55005.9090503@mit.edu>
Date: Tue, 13 Jan 2015 12:04:05 -0500
From: Greg Hudson <ghudson@mit.edu>
MIME-Version: 1.0
To: Shawn M Emery <shawn.emery@oracle.com>, krbdev@mit.edu
In-Reply-To: <54B4BF20.1080203@oracle.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On 01/13/2015 01:45 AM, Shawn M Emery wrote:
> We may want to change other functions like krb5_425_conv_principal
> if this is the intended conditional.
That does appear broken, and also appears to be our only use of
profile_iterator() outside of the profile itself.
Prior to 1.10 that code would get a PROF_MAGIC_ITERATOR error from the
invalid call after the final iteration, so it would function even
though it was incorrectly using the interface. I think it would be
good to restore the 1.9 behavior by adding a null pointer check to the
magic check, but it would also be good to fix krb5_425_conv_principal
to correctly detect the final iteration.
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
