[19070] in Kerberos_V5_Development

home help back first fref pref prev next nref lref last post

Re: Questions about iter check in profile_iterator()

daemon@ATHENA.MIT.EDU (Shawn M Emery)
Tue Jan 13 01:45:18 2015

Message-ID: <54B4BF20.1080203@oracle.com>
Date: Mon, 12 Jan 2015 23:45:52 -0700
From: Shawn M Emery <shawn.emery@oracle.com>
MIME-Version: 1.0
To: krbdev@mit.edu
In-Reply-To: <54B493B7.4020909@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu

On 01/12/15 08:40 PM, Greg Hudson wrote:
> On 01/12/2015 07:06 PM, Neng Xue wrote:
>> So my question is that do we use the
>> profile_iterator() in the wrong way or there should be an iter check in
>> the profile_iterator()? Thanks.
> The loop condition should be "state != NULL" rather than "code == 0".
> profile_iterator_create returns 0 and sets *iter_p to NULL on the last
> iteration.

We may want to change other functions like krb5_425_conv_principal if 
this is the intended conditional.

Shawn.
--
> On 01/12/2015 08:13 PM, Will Fiveash wrote:
>> So in the profile_iterator call to profile_node_iterator() the
>> &iter->idata arg is iter_p for profile_node_iterator?  Seems odd to me.
> I don't see what is odd about that.  iter->idata holds the node iterator
> state.
> _______________________________________________
> krbdev mailing list             krbdev@mit.edu
> https://mailman.mit.edu/mailman/listinfo/krbdev
>
>

_______________________________________________
krbdev mailing list             krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev

home help back first fref pref prev next nref lref last post