[17270] in Kerberos_V5_Development
Re: [PATCH 2/4] Utility functions to move allocations from
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Oct 6 13:42:18 2011
From: Greg Hudson <ghudson@mit.edu>
To: Sam Hartman <hartmans@painless-security.com>
In-Reply-To: <1317921933-22035-3-git-send-email-hartmans@painless-security.com>
Date: Thu, 06 Oct 2011 13:42:14 -0400
Message-ID: <1317922934.1548.10.camel@t410>
Mime-Version: 1.0
Cc: Kevin Wasserman <kevin.wasserman@painless-security.com>,
"krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
These helper names are much too long. Since they have no external
linkage and aren't public, they don't need namespace prefixes. I
suggest "k5buf_to_gss" and "data_to_gss".
Both helpers need explanatory comments to note that they invalidate the
source objects.
Don't muck with the internals of a k5buf in the k5buf helper. There's
currently no API to invalidate a k5buf (it's assumed that the caller is
smart enough to stop using it if it takes ownership of the data
pointer), so just don't do that for now.
In the krb5_data helper, setting input_k5data = NULL does nothing. Set
*input_k5data = empty_data().
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
