[17269] in Kerberos_V5_Development
Re: [PATCH 1/4] Add new public header gssapi_alloc.h
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Oct 6 13:31:11 2011
From: Greg Hudson <ghudson@mit.edu>
To: Sam Hartman <hartmans@painless-security.com>
In-Reply-To: <1317921933-22035-2-git-send-email-hartmans@painless-security.com>
Date: Thu, 06 Oct 2011 13:31:06 -0400
Message-ID: <1317922266.1548.2.camel@t410>
Mime-Version: 1.0
Cc: Kevin Wasserman <kevin.wasserman@painless-security.com>,
"krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On Thu, 2011-10-06 at 13:25 -0400, Sam Hartman wrote:
> + char *copy = gssalloc_malloc(strlen(str)+1);
> + if (copy) {
> + strcpy(copy, str);
> + }
Don't use strcpy here; it gets flagged in Coverity. Remember the length
and use strlcpy.
http://k5wiki.kerberos.org/wiki/Coding_style/Practices#String_Handling
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
