[17135] in Kerberos_V5_Development
Re: [RFC][PATCH] krb5 => libverto main loop
daemon@ATHENA.MIT.EDU (Nathaniel McCallum)
Fri Sep 2 11:23:06 2011
From: Nathaniel McCallum <npmccallum@redhat.com>
To: Greg Hudson <ghudson@mit.edu>
Date: Fri, 02 Sep 2011 11:22:57 -0400
In-Reply-To: <1314920917.24488.125.camel@t410>
Message-ID: <1314976980.7344.6.camel@localhost>
Mime-Version: 1.0
Cc: "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On Thu, 2011-09-01 at 19:48 -0400, Greg Hudson wrote:
> Very close to ready. I only found these minor issues:
>
> * kdc/main.c: on_monitor_sighup sets sighup_received to 1, but
> create_workers checks if its value is SIGHUP. (It so happens that
> SIGHUP is generally defined to 1, but I assume you didn't mean to rely
> on that.)
>
> * Line 1571 of net-server.c is extended past 79 characters and should be
> wrapped.
>
> * As discussed in IRC, kadmind invokes krb5_klog_reopen() after
> receiving SIGHUP. This behavior should be preserved in patches 4 and 5.
Ok, all these are fixed, plus another bug I found (accidentally
requiring child events from verto, which we removed). The branch is
rebased on upstream master as of right now and can be found here:
https://github.com/npmccallum/krb5-anonsvn/commits/verto
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
