[17134] in Kerberos_V5_Development
Re: [RFC][PATCH] krb5 => libverto main loop
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Sep 1 19:48:43 2011
From: Greg Hudson <ghudson@mit.edu>
To: Nathaniel McCallum <npmccallum@redhat.com>
In-Reply-To: <1314893708.7344.4.camel@localhost>
Date: Thu, 01 Sep 2011 19:48:37 -0400
Message-ID: <1314920917.24488.125.camel@t410>
Mime-Version: 1.0
Cc: "krbdev@mit.edu" <krbdev@mit.edu>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
Very close to ready. I only found these minor issues:
* kdc/main.c: on_monitor_sighup sets sighup_received to 1, but
create_workers checks if its value is SIGHUP. (It so happens that
SIGHUP is generally defined to 1, but I assume you didn't mean to rely
on that.)
* Line 1571 of net-server.c is extended past 79 characters and should be
wrapped.
* As discussed in IRC, kadmind invokes krb5_klog_reopen() after
receiving SIGHUP. This behavior should be preserved in patches 4 and 5.
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
