[1588] in Kerberos-V5-bugs
Re: Patches to Beta 5-1/2 (24 July snapshot)
daemon@ATHENA.MIT.EDU (Derek Atkins)
Mon Aug 7 20:00:04 1995
Date: Mon, 7 Aug 1995 16:59:59 -0700
From: Derek Atkins <Derek.Atkins@Eng.Sun.COM>
To: tytso@MIT.EDU
Cc: krb5-bugs@MIT.EDU
In-Reply-To: <9508072344.AA26005@dcl.MIT.EDU> (tytso@MIT.EDU)
> Couple of comments. First of all, your patch to in_tkt_ktb.c is a
> perfect proof about how people who claim that going to all efforts to
> avoid "goto" statements are in space. It took me a quite a bit of time
> to figure out what the heck your patch was trying to do. I assume that
> it was making sure the keytab file was being closed when an error
> occured.
Yea, this was the point. And you're right, I probably should have
used a goto in this instance. I even considered it when I was making
the change, but for some reason the "never use goto" training took
over.
> Secondly, a few comments about what each of your patches do, especially
> when it may not be immediately obvious, are greatly appreciated. It can
> save me quite a bit of time.
Mmm.. Perhaps I should have included more explanation. If you'd like
me to re-submit the patches with explanations, I can do that. Many of
the patches are, IMHO, self-explanatory, such as the addition of
$(SHELL) to commands, etc.
> Finally, what are the patches to the Makefiles of the form:
>
> + kdb5_destroy.o: kdb5_destroy.c
>
> for? Don't tell me SunSoft's make is so broken that it can't even
> figure out a dependency rule this basic on its own?
To play devil's advocate, how is make supposed to know what
source-file to look for. It could be a .c file, a .s file, a .f file;
it could be a .y file that needs to be compiled to a .c file and then
to a .o file... I don't consider this a bug in make. I believe that
you should include an explicit dependency on all the source files.
And yes, SunSoft make does fail in the cases where such a dependency
does not exist.
-derek
