[1587] in Kerberos-V5-bugs
Re: Patches to Beta 5-1/2 (24 July snapshot)
daemon@ATHENA.MIT.EDU (Theodore Ts'o)
Mon Aug 7 19:44:17 1995
Date: Mon, 7 Aug 1995 19:44:07 -0400
From: Theodore Ts'o <tytso@MIT.EDU>
To: warlord@mtv4s1.Eng.Sun.COM
Cc: krb5-bugs@MIT.EDU
In-Reply-To: Derek Atkins's message of Mon, 7 Aug 1995 13:58:22 -0700,
<9508072058.AA18501@squeamish-ossifrage.Eng.Sun.COM>
Couple of comments. First of all, your patch to in_tkt_ktb.c is a
perfect proof about how people who claim that going to all efforts to
avoid "goto" statements are in space. It took me a quite a bit of time
to figure out what the heck your patch was trying to do. I assume that
it was making sure the keytab file was being closed when an error
occured.
Secondly, a few comments about what each of your patches do, especially
when it may not be immediately obvious, are greatly appreciated. It can
save me quite a bit of time.
Finally, what are the patches to the Makefiles of the form:
+ kdb5_destroy.o: kdb5_destroy.c
for? Don't tell me SunSoft's make is so broken that it can't even
figure out a dependency rule this basic on its own?
- Ted
