[11275] in Kerberos-V5-bugs
[krbdev.mit.edu #6618] Support optional creation of PID files for
daemon@ATHENA.MIT.EDU (Russ Allbery)
Thu Dec 31 16:31:20 2009
Mail-followup-to: rt@krbdev.mit.edu
mail-copies-to: never
From: "Russ Allbery <rra@stanford.edu> via RT" <rt-comment@krbdev.MIT.EDU>
In-Reply-To: <rt-6618@krbdev.mit.edu>
Message-ID: <rt-6618-31972.7.55444059379911@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #6618'":;"'AdminCc of krbdev.mit.edu Ticket #6618'":;@MIT.EDU
Date: Thu, 31 Dec 2009 16:30:44 -0500 (EST)
Reply-To: rt-comment@krbdev.MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu
[ghudson - Thu Dec 31 13:11:33 2009]:
> What I'd like to see, in both cases, is pid file setup moved into a
> static helper function. This would reduce the number of duplicate
> cleanup sequences from two to one (both functions would benefit from
> flow control which avoids the need for duplicate cleanup sequences, but
> that's not your problem) and would also eliminate the need for inner
> variable declarations, which are discouraged by our coding practices.
Oh, sure, that's an easy fix and a good idea. Attached is a new version
of the patch.
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs
