[11274] in Kerberos-V5-bugs
[krbdev.mit.edu #6618] Support optional creation of PID files for
daemon@ATHENA.MIT.EDU (Greg Hudson via RT)
Thu Dec 31 13:12:00 2009
Mail-followup-to: rt@krbdev.mit.edu
mail-copies-to: never
From: "Greg Hudson via RT" <rt-comment@krbdev.MIT.EDU>
In-Reply-To: <rt-6618@krbdev.mit.edu>
Message-ID: <rt-6618-31971.3.05171688054827@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #6618'":;"'AdminCc of krbdev.mit.edu Ticket #6618'":;@MIT.EDU
Date: Thu, 31 Dec 2009 13:11:34 -0500 (EST)
Reply-To: rt-comment@krbdev.MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu
What I'd like to see, in both cases, is pid file setup moved into a
static helper function. This would reduce the number of duplicate
cleanup sequences from two to one (both functions would benefit from
flow control which avoids the need for duplicate cleanup sequences, but
that's not your problem) and would also eliminate the need for inner
variable declarations, which are discouraged by our coding practices.
That said, the patches look functionally correct, and it's probably
better to commit them in their current form before the 1.8 branch (which
may happen as early as Monday) than to wait until after for the sake of
cleanliness.
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs
