[31193] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix profile crash on memory exhaustion

daemon@ATHENA.MIT.EDU (ghudson@mit.edu)
Mon Dec 5 12:00:53 2022

From: ghudson@mit.edu
To: <cvs-krb5@mit.edu>
Message-ID: <20221205170000.BA64610500B@krbdev.mit.edu>
Date: Mon,  5 Dec 2022 12:00:00 -0500 (EST)
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/2929ec400c174bc848a9c438a61b0e3506b91d0e
commit 2929ec400c174bc848a9c438a61b0e3506b91d0e
Author: ChenChen Zhou <357726167@qq.com>
Date:   Thu Nov 24 21:59:21 2022 +0800

    Fix profile crash on memory exhaustion
    
    In profile_get_values(), if init_list() fails to allocate values.list,
    end_list() will dereference a null pointer.  Fix end_list() to handle
    list->list being null.
    
    [ghudson@mit.edu: rewrote commit message]
    
    ticket: 9078 (new)

 src/util/profile/prof_get.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/profile/prof_get.c b/src/util/profile/prof_get.c
index 0e14200ca..12c7b9641 100644
--- a/src/util/profile/prof_get.c
+++ b/src/util/profile/prof_get.c
@@ -62,7 +62,7 @@ static void end_list(struct profile_string_list *list, char ***ret_list)
         *ret_list = list->list;
         return;
     } else {
-        for (cp = list->list; *cp; cp++)
+        for (cp = list->list; cp && *cp; cp++)
             free(*cp);
         free(list->list);
     }
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post