[31520] in CVS-changelog-for-Kerberos-V5
krb5 commit: Make configure.ac work with autoconf 2.73
daemon@ATHENA.MIT.EDU (ghudson@mit.edu)
Mon Apr 13 21:06:24 2026
From: ghudson@mit.edu
To: cvs-krb5@mit.edu
Message-Id: <20260414010617.E4098104AF7@krbdev.mit.edu>
Date: Mon, 13 Apr 2026 21:06:17 -0400 (EDT)
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/b7290e0cab5b7e39cd4aa7c098beb18a886d4a1d
commit b7290e0cab5b7e39cd4aa7c098beb18a886d4a1d
Author: Samuel Cabrero <scabrero@suse.com>
Date: Tue Feb 17 16:57:40 2026 +0100
Make configure.ac work with autoconf 2.73
autoreconf requires "AC_INIT" to appear in configure.ac. Prior to
autoconf 2.73, our indirect invocation via K5_AC_INIT() was
sufficient, but now the regular expression match checks for word
boundaries. Get rid of K5_AC_INIT(), moving the version extraction
code from aclocal.m4 to a new file version.m4. In the moved
versioning code, use m4_fatal() to simplify error handling.
[ghudson@mit.edu: made the m4_fatal() change; rewrote commit message]
ticket: 9202 (new)
src/aclocal.m4 | 24 ------------------------
src/configure.ac | 4 +++-
src/version.m4 | 14 ++++++++++++++
3 files changed, 17 insertions(+), 25 deletions(-)
diff --git a/src/aclocal.m4 b/src/aclocal.m4
index bd75a8d73..f6dc817bf 100644
--- a/src/aclocal.m4
+++ b/src/aclocal.m4
@@ -16,30 +16,6 @@ ac_config_fragdir=$ac_reltopdir/config
AC_CONFIG_AUX_DIR(K5_TOPDIR/config)
])dnl
dnl
-dnl Version info.
-dnl
-pushdef([x],esyscmd([sed -n 's/#define \([A-Z0-9_]*\)[ \t]*\(.*\)/\1=\2/p' < ]K5_TOPDIR/patchlevel.h))
-define([PL_KRB5_MAJOR_RELEASE],regexp(x,[KRB5_MAJOR_RELEASE=\(.*\)],[\1]))
-ifelse(PL_KRB5_MAJOR_RELEASE,,[errprint([Can't determine KRB5_MAJOR_RELEASE value from patchlevel.h.
-]) m4exit(1) dnl sometimes that does not work?
-builtin(m4exit,1)])
-define([PL_KRB5_MINOR_RELEASE],regexp(x,[KRB5_MINOR_RELEASE=\(.*\)],[\1]))
-ifelse(PL_KRB5_MINOR_RELEASE,,[errprint([Can't determine KRB5_MINOR_RELEASE value from patchlevel.h.
-]) m4exit(1) dnl sometimes that does not work?
-builtin(m4exit,1)])
-define([PL_KRB5_PATCHLEVEL],regexp(x,[KRB5_PATCHLEVEL=\(.*\)],[\1]))
-ifelse(PL_KRB5_PATCHLEVEL,,[errprint([Can't determine KRB5_PATCHLEVEL value from patchlevel.h.
-]) m4exit(1) dnl sometimes that does not work?
-builtin(m4exit,1)])
-define([PL_KRB5_RELTAIL],regexp(x,[KRB5_RELTAIL="\(.*\)"],[\1]))
-dnl RELTAIL is allowed to not be defined.
-popdef([x])
-define([K5_VERSION],PL_KRB5_MAJOR_RELEASE.PL_KRB5_MINOR_RELEASE[]ifelse(PL_KRB5_PATCHLEVEL,0,,.PL_KRB5_PATCHLEVEL)ifelse(PL_KRB5_RELTAIL,,,-PL_KRB5_RELTAIL))
-define([K5_BUGADDR],krb5-bugs@mit.edu)
-define([K5_AC_INIT],[AC_INIT(Kerberos 5, K5_VERSION, K5_BUGADDR, krb5)
-AC_CONFIG_SRCDIR($1)
-build_dynobj=no])
-dnl
dnl drop in standard rules for all configure files -- CONFIG_RULES
dnl
AC_DEFUN(CONFIG_RULES,[dnl
diff --git a/src/configure.ac b/src/configure.ac
index ed6724501..f1cbe4b13 100644
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -1,4 +1,6 @@
-K5_AC_INIT([aclocal.m4])
+m4_include([version.m4])
+AC_INIT(Kerberos 5, K5_VERSION, K5_BUGADDR, krb5)
+AC_CONFIG_SRCDIR([aclocal.m4])
# If $runstatedir isn't set by autoconf (<2.70), set it manually.
if test x"$runstatedir" = x; then
diff --git a/src/version.m4 b/src/version.m4
new file mode 100644
index 000000000..4b08edde5
--- /dev/null
+++ b/src/version.m4
@@ -0,0 +1,14 @@
+define([K5_TOPDIR],[.])dnl
+dnl
+pushdef([x],esyscmd([sed -n 's/#define \([A-Z0-9_]*\)[ \t]*\(.*\)/\1=\2/p' < ]K5_TOPDIR/patchlevel.h))
+define([PL_KRB5_MAJOR_RELEASE],regexp(x,[KRB5_MAJOR_RELEASE=\(.*\)],[\1]))
+ifelse(PL_KRB5_MAJOR_RELEASE,,[m4_fatal([Can't determine KRB5_MAJOR_RELEASE value from patchlevel.h.])])
+define([PL_KRB5_MINOR_RELEASE],regexp(x,[KRB5_MINOR_RELEASE=\(.*\)],[\1]))
+ifelse(PL_KRB5_MINOR_RELEASE,,[m4_fatal([Can't determine KRB5_MINOR_RELEASE value from patchlevel.h.])])
+define([PL_KRB5_PATCHLEVEL],regexp(x,[KRB5_PATCHLEVEL=\(.*\)],[\1]))
+ifelse(PL_KRB5_PATCHLEVEL,,[m4_fatal([Can't determine KRB5_PATCHLEVEL value from patchlevel.h.])])
+define([PL_KRB5_RELTAIL],regexp(x,[KRB5_RELTAIL="\(.*\)"],[\1]))
+dnl RELTAIL is allowed to not be defined.
+popdef([x])
+m4_define([K5_VERSION],PL_KRB5_MAJOR_RELEASE.PL_KRB5_MINOR_RELEASE[]ifelse(PL_KRB5_PATCHLEVEL,0,,.PL_KRB5_PATCHLEVEL)ifelse(PL_KRB5_RELTAIL,,,-PL_KRB5_RELTAIL))
+m4_define([K5_BUGADDR],krb5-bugs@mit.edu)
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5