[28457] in CVS-changelog-for-Kerberos-V5
krb5 commit: Avoid closing fd -1 in libkrad
daemon@ATHENA.MIT.EDU (Greg Hudson)
Sat Jul 12 15:19:37 2014
Date: Sat, 12 Jul 2014 15:19:26 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201407121919.s6CJJQaO021492@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/315d1ef769d3e3e7cc17884623c1baaad680c26b
commit 315d1ef769d3e3e7cc17884623c1baaad680c26b
Author: Lukas Slebodnik <lslebodn@redhat.com>
Date: Sat Jun 21 16:43:12 2014 +0200
Avoid closing fd -1 in libkrad
If a krad_remote is released before its fd is set, we could close the
file descriptor -1, which is harmless but incorrect. Check the fd in
remote_disconnect to avoid this.
[ghudson@mit.edu: clarified commit message, minor style change]
src/lib/krad/remote.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/lib/krad/remote.c b/src/lib/krad/remote.c
index bea1429..795485f 100644
--- a/src/lib/krad/remote.c
+++ b/src/lib/krad/remote.c
@@ -144,7 +144,8 @@ request_start_timer(request *r, verto_ctx *vctx)
static void
remote_disconnect(krad_remote *rr)
{
- close(rr->fd);
+ if (rr->fd >= 0)
+ close(rr->fd);
verto_del(rr->io);
rr->fd = -1;
rr->io = NULL;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
