[28456] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix error check in krb5_ldap_parse_principal_name
daemon@ATHENA.MIT.EDU (Greg Hudson)
Sat Jul 12 15:19:36 2014
Date: Sat, 12 Jul 2014 15:19:27 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201407121919.s6CJJRJU021511@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/b6810da129512b6d0200580d78d22d38cc214e21
commit b6810da129512b6d0200580d78d22d38cc214e21
Author: Lukas Slebodnik <lslebodn@redhat.com>
Date: Sat Jun 21 17:09:31 2014 +0200
Fix error check in krb5_ldap_parse_principal_name
Test the correct variable for NULL to detect a strdup failure.
[ghudson@mit.edu: clarified commit message]
src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c b/src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c
index 21695a9..44bf339 100644
--- a/src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c
+++ b/src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c
@@ -412,7 +412,7 @@ krb5_ldap_parse_principal_name(char *i_princ_name, char **o_princ_name)
at_rlm_name = strrchr(i_princ_name, '@');
if (!at_rlm_name) {
*o_princ_name = strdup(i_princ_name);
- if (!o_princ_name)
+ if (!*o_princ_name)
return ENOMEM;
} else {
k5_buf_init_dynamic(&buf);
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
