[27068] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix policy refcount corruption race in dump
daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Oct 5 15:32:31 2012
Date: Fri, 5 Oct 2012 15:32:28 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201210051932.q95JWSnx014143@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/e65a16d898f3a686525e83661f4fd86c76e27bbf
commit e65a16d898f3a686525e83661f4fd86c76e27bbf
Author: Nicolas Williams <nico@cryptonector.com>
Date: Thu Sep 27 17:10:41 2012 -0500
Fix policy refcount corruption race in dump
ticket: 7384
src/kadmin/dbutil/dump.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/kadmin/dbutil/dump.c b/src/kadmin/dbutil/dump.c
index 1009679..63f48f3 100644
--- a/src/kadmin/dbutil/dump.c
+++ b/src/kadmin/dbutil/dump.c
@@ -1476,17 +1476,17 @@ dump_db(argc, argv)
arglist.kcontext = util_context;
fprintf(arglist.ofile, "%s", dump->header);
- if (dump_sno) {
- /*
- * We grab the lock twice (once again in the iterator call),
- * but that's ok since the lock func handles incr locks held.
- */
- if (krb5_db_lock(util_context, KRB5_LOCKMODE_SHARED)) {
- fprintf(stderr,
- _("%s: Couldn't grab lock\n"), progname);
- goto error;
- }
+ /*
+ * We grab the lock twice (once again in the iterator call),
+ * but that's ok since the lock func handles incr locks held.
+ */
+ if (krb5_db_lock(util_context, KRB5_LOCKMODE_SHARED)) {
+ fprintf(stderr,
+ _("%s: Couldn't grab lock\n"), progname);
+ goto error;
+ }
+ if (dump_sno) {
if (ipropx_version)
fprintf(f, " %u", IPROPX_VERSION);
fprintf(f, " %u", log_ctx->ulog->kdb_last_sno);
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
