[27067] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Sync iprop header in kdb5_util dump

daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Oct 5 15:13:18 2012

Date: Fri, 5 Oct 2012 15:13:07 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201210051913.q95JD7M4003547@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/3221bdba150ac3910dc7058f02c71008ef56bf52
commit 3221bdba150ac3910dc7058f02c71008ef56bf52
Author: Nicolas Williams <nico@cryptonector.com>
Date:   Fri Oct 5 14:56:35 2012 -0400

    Sync iprop header in kdb5_util dump
    
    [ghudson@mit.edu: split out from previous commit]

 src/kadmin/dbutil/dump.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/src/kadmin/dbutil/dump.c b/src/kadmin/dbutil/dump.c
index e72de63..1009679 100644
--- a/src/kadmin/dbutil/dump.c
+++ b/src/kadmin/dbutil/dump.c
@@ -2905,6 +2905,16 @@ load_db(argc, argv)
                     last_seconds;
                 log_ctx->ulog->kdb_last_time.useconds =
                     last_useconds;
+
+                /*
+                 * Sync'ing the header is not necessary on any OS and
+                 * filesystem where the filesystem and virtual memory block
+                 * cache are unified, which is pretty much all cases that we
+                 * care about.  However, technically speaking we must msync()
+                 * in order for our writes here to be visible to a running
+                 * kpropd.
+                 */
+                ulog_sync_header(log_ctx->ulog);
             }
         }
     }
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post