[999] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[D-O-H] r988 - in trunk/owl/perl/modules/IRC/lib/BarnOwl/Module: . IRC

daemon@ATHENA.MIT.EDU (geofft@MIT.EDU)
Thu Oct 29 18:12:00 2009

Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@nelhage.com
Date: Wed, 19 Mar 2008 15:46:44 -0400
To: dirty-owl-hackers@MIT.EDU
From: geofft@MIT.EDU
Reply-To: dirty-owl-hackers@MIT.EDU

Author: geofft
Date: 2008-03-19 15:46:43 -0400 (Wed, 19 Mar 2008)
New Revision: 988

Modified:
   trunk/owl/perl/modules/IRC/lib/BarnOwl/Module/IRC.pm
   trunk/owl/perl/modules/IRC/lib/BarnOwl/Module/IRC/Connection.pm
Log:
IRC: explicitly include the network (-a $alias) in reply commands.

This may be unnecessary because :irc-msg looks at getcurmsg() if it cannot
automatically determine the network.



Modified: trunk/owl/perl/modules/IRC/lib/BarnOwl/Module/IRC/Connection.pm
===================================================================
--- trunk/owl/perl/modules/IRC/lib/BarnOwl/Module/IRC/Connection.pm	2008-03-19 03:57:24 UTC (rev 987)
+++ trunk/owl/perl/modules/IRC/lib/BarnOwl/Module/IRC/Connection.pm	2008-03-19 19:46:43 UTC (rev 988)
@@ -107,9 +107,9 @@
           (notice     => 'true') : (),
         is_private($recipient) ?
           (isprivate  => 'true') : (channel => $recipient),
-        replycmd    => 'irc-msg ' .
+        replycmd    => 'irc-msg -a ' . $self->alias . ' ' .
             (is_private($recipient) ? $evt->nick : $recipient),
-        replysendercmd => 'irc-msg ' . $evt->nick
+        replysendercmd => 'irc-msg -a ' . $self->alias . ' ' . $evt->nick
        );
 
     BarnOwl::queue_message($msg);
@@ -157,6 +157,8 @@
     my $msg = $self->new_message($evt,
         loginout   => 'login',
         channel    => $evt->to,
+        replycmd => 'irc-msg -a ' . $self->alias . ' ' . $evt->nick
+        replysendercmd => 'irc-msg -a ' . $self->alias . ' ' . $evt->nick
         );
     BarnOwl::queue_message($msg);
 }
@@ -166,6 +168,8 @@
     my $msg = $self->new_message($evt,
         loginout   => 'logout',
         channel    => $evt->to,
+        replycmd => 'irc-msg -a ' . $self->alias . ' ' . $evt->nick
+        replysendercmd => 'irc-msg -a ' . $self->alias . ' ' . $evt->nick
         );
     BarnOwl::queue_message($msg);
 }

Modified: trunk/owl/perl/modules/IRC/lib/BarnOwl/Module/IRC.pm
===================================================================
--- trunk/owl/perl/modules/IRC/lib/BarnOwl/Module/IRC.pm	2008-03-19 03:57:24 UTC (rev 987)
+++ trunk/owl/perl/modules/IRC/lib/BarnOwl/Module/IRC.pm	2008-03-19 19:46:43 UTC (rev 988)
@@ -198,7 +198,7 @@
     if(@_) {
         process_msg($conn, $to, join(" ", @_));
     } else {
-        BarnOwl::start_edit_win("/msg $to -a " . $conn->alias, sub {process_msg($conn, $to, @_)});
+        BarnOwl::start_edit_win("/msg -a " . $conn->alias . " $to", sub {process_msg($conn, $to, @_)});
     }
 }
 
@@ -219,8 +219,8 @@
         sender      => $conn->nick,
         is_private($to) ?
           (isprivate  => 'true') : (channel => $to),
-        replycmd    => "irc-msg $to",
-        replysendercmd => "irc-msg $to"
+        replycmd    => "irc-msg -a " . $conn->alias . " $to",
+        replysendercmd => "irc-msg -a " . $conn->alias . " $to"
        );
     BarnOwl::queue_message($msg);
 }


home help back first fref pref prev next nref lref last post