[924] in BarnOwl Developers
[D-O-H] r911 - trunk/owl/perl/modules/Jabber/lib/BarnOwl/Module
daemon@ATHENA.MIT.EDU (asedeno@MIT.EDU)
Thu Oct 29 18:11:11 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@nelhage.com
To: dirty-owl-hackers@mit.edu
From: asedeno@MIT.EDU
Reply-to: dirty-owl-hackers@MIT.EDU
Date: Wed, 30 Jan 2008 15:49:37 -0500 (EST)
Author: asedeno
Date: 2008-01-30 15:49:35 -0500 (Wed, 30 Jan 2008)
New Revision: 911
Modified:
trunk/owl/perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm
Log:
Jabber Buddy Lists:
* Query the jabber:show_offline_buddies once when invoking onGetBuddyList()
* Don't bold online roster entries when hiding offline ones
Modified: trunk/owl/perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm
===================================================================
--- trunk/owl/perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm 2008-01-30 01:47:41 UTC (rev 910)
+++ trunk/owl/perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm 2008-01-30 20:49:35 UTC (rev 911)
@@ -134,6 +134,8 @@
}
}
+our $showOffline = 0;
+
sub blist_listBuddy {
my $roster = shift;
my $buddy = shift;
@@ -149,10 +151,10 @@
my %rq = $roster->resourceQuery( $buddy, $res );
$blistStr .= " [" . ( $rq{show} ? $rq{show} : 'online' ) . "]";
$blistStr .= " " . $rq{status} if $rq{status};
- $blistStr = BarnOwl::Style::boldify($blistStr);
+ $blistStr = BarnOwl::Style::boldify($blistStr) if $showOffline;
}
else {
- return '' if (BarnOwl::getvar('jabber:show_offline_buddies') eq 'off');
+ return '' unless $showOffline;
if ($jq{ask}) {
$blistStr .= " [pending]";
}
@@ -195,6 +197,7 @@
}
sub onGetBuddyList {
+ $showOffline = BarnOwl::getvar('jabber:show_offline_buddies') eq 'on';
my $blist = "";
foreach my $jid ($conn->getJIDs()) {
$blist .= getSingleBuddyList($jid);
