[921] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[D-O-H] r908 - branches/barnowl_sqlite/owl/perl/lib/BarnOwl/MessageList

daemon@ATHENA.MIT.EDU (nelhage@MIT.EDU)
Thu Oct 29 18:11:10 2009

Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@nelhage.com
To: dirty-owl-hackers@MIT.EDU
From: nelhage@MIT.EDU
Reply-to: dirty-owl-hackers@MIT.EDU
Date: Thu, 24 Jan 2008 20:53:30 -0500 (EST)

Author: nelhage
Date: 2008-01-24 20:53:29 -0500 (Thu, 24 Jan 2008)
New Revision: 908

Modified:
   branches/barnowl_sqlite/owl/perl/lib/BarnOwl/MessageList/SQL.pm
Log:
Explicitly close database handles when we're done with them


Modified: branches/barnowl_sqlite/owl/perl/lib/BarnOwl/MessageList/SQL.pm
===================================================================
--- branches/barnowl_sqlite/owl/perl/lib/BarnOwl/MessageList/SQL.pm	2008-01-25 01:46:06 UTC (rev 907)
+++ branches/barnowl_sqlite/owl/perl/lib/BarnOwl/MessageList/SQL.pm	2008-01-25 01:53:29 UTC (rev 908)
@@ -129,8 +129,13 @@
     my $self = shift;
     my %msg;
     my $msg;
+    return undef unless $self->msg_iter;
     my $next = $self->msg_iter->fetch;
     unless($next) {
+        $self->msg_iter->finish;
+        $self->attr_iter->finish;
+        $self->msg_iter(undef);
+        $self->attr_iter(undef);
         return undef;
     }
     load_base(\%msg, $next);


home help back first fref pref prev next nref lref last post