[892] in BarnOwl Developers
[D-O-H] r879 - branches/barnowl_sqlite/owl
daemon@ATHENA.MIT.EDU (nelhage@MIT.EDU)
Thu Oct 29 18:10:50 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
To: dirty-owl-hackers@mit.edu
From: nelhage@MIT.EDU
Reply-to: dirty-owl-hackers@MIT.EDU
Date: Tue, 15 Jan 2008 17:03:02 -0500 (EST)
Author: nelhage
Date: 2008-01-15 17:03:01 -0500 (Tue, 15 Jan 2008)
New Revision: 879
Modified:
branches/barnowl_sqlite/owl/message.c
branches/barnowl_sqlite/owl/messagelist.c
branches/barnowl_sqlite/owl/owl.c
Log:
No need for explicit release/retain; Mortalize SVs that are added to the message list
Modified: branches/barnowl_sqlite/owl/message.c
===================================================================
--- branches/barnowl_sqlite/owl/message.c 2008-01-15 21:49:20 UTC (rev 878)
+++ branches/barnowl_sqlite/owl/message.c 2008-01-15 22:03:01 UTC (rev 879)
@@ -929,16 +929,6 @@
if (ptr) ptr[0]='\0';
}
-void owl_message_retain(owl_message *m)
-{
- SvREFCNT_inc((SV*)m);
-}
-
-void owl_message_release(owl_message *m)
-{
- SvREFCNT_dec((SV*)m);
-}
-
void owl_message_free(owl_message *m)
{
owl_message_invalidate_format(m);
Modified: branches/barnowl_sqlite/owl/messagelist.c
===================================================================
--- branches/barnowl_sqlite/owl/messagelist.c 2008-01-15 21:49:20 UTC (rev 878)
+++ branches/barnowl_sqlite/owl/messagelist.c 2008-01-15 22:03:01 UTC (rev 879)
@@ -70,7 +70,7 @@
);
// When we insert the message, perl code takes ownership of it, so
// we relinquish our reference
- SvREFCNT_dec((SV*)msg);
+ sv_2mortal(msg);
}
void owl_messagelist_expunge(owl_messagelist *ml)
Modified: branches/barnowl_sqlite/owl/owl.c
===================================================================
--- branches/barnowl_sqlite/owl/owl.c 2008-01-15 21:49:20 UTC (rev 878)
+++ branches/barnowl_sqlite/owl/owl.c 2008-01-15 22:03:01 UTC (rev 879)
@@ -619,8 +619,6 @@
return 0;
}
- owl_message_retain(m);
-
/* add it to the global list */
owl_messagelist_append_element(owl_global_get_msglist(&g), m);
/* add it to any necessary views; right now there's only the current view */
@@ -687,7 +685,6 @@
/* log the message if we need to */
owl_log_message(m);
- owl_message_release(m);
return 1;
}
