[886] in BarnOwl Developers
[D-O-H] r874 - branches/barnowl_sqlite/owl
daemon@ATHENA.MIT.EDU (nelhage@MIT.EDU)
Thu Oct 29 18:10:46 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
To: dirty-owl-hackers@mit.edu
From: nelhage@MIT.EDU
Reply-to: dirty-owl-hackers@MIT.EDU
Date: Mon, 14 Jan 2008 23:51:18 -0500 (EST)
Author: nelhage
Date: 2008-01-14 23:51:18 -0500 (Mon, 14 Jan 2008)
New Revision: 874
Modified:
branches/barnowl_sqlite/owl/messagelist.c
Log:
Actually free the the SV as well as dec the refcnt
Modified: branches/barnowl_sqlite/owl/messagelist.c
===================================================================
--- branches/barnowl_sqlite/owl/messagelist.c 2008-01-15 03:14:21 UTC (rev 873)
+++ branches/barnowl_sqlite/owl/messagelist.c 2008-01-15 04:51:18 UTC (rev 874)
@@ -59,18 +59,18 @@
return SvROK(msg) ? msg : NULL;
}
-void owl_messagelist_append_element(owl_messagelist *ml, void *element)
+void owl_messagelist_append_element(owl_messagelist *ml, owl_message *msg)
{
OWL_PERL_CALL_METHOD(ml, "add_message",
- XPUSHs((SV*)element); ,
+ XPUSHs((SV*)msg); ,
// Error
"Error in add_message: %s",
1, // Fatal
OWL_PERL_VOID_CALL
);
// When we insert the message, perl code takes ownership of it, so
- // we relinquish our reference count on the HV that is the message
- SvREFCNT_dec(SvRV((SV*)element));
+ // we relinquish our reference
+ SvREFCNT_dec((SV*)msg);
}
void owl_messagelist_expunge(owl_messagelist *ml)
