[4316] in BarnOwl Developers
Re: [barnowl/barnowl] Make the basic style inherit from the default
daemon@ATHENA.MIT.EDU (Daniel JB Clark)
Tue Nov 3 13:06:13 2026
Date: Tue, 03 Nov 2026 10:06:09 -0800
From: Daniel JB Clark <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSJFJD5WIV6MUJAI4G3LMNWJDEVBNHHQAAAAAFYAB243@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/198@github.com>
----==_mimepart_6aea22917cb82_f312d05846c2
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
djbclark left a comment (barnowl/barnowl#198)
Testing status: **not done yet.** I ran this PR's own tests on master and on the branch, plus a live BarnOwl check with injected messages (before/after screenshots and logs), but I still need to review that evidence myself before calling it tested.
Findings: the new `t/style-basic.t` fails on master (cannot call `format_message`) and passes on the branch. Live: `:view -s basic` shows `<unformatted message>` and the error "Can't locate object method format_message" on master, and renders normally on the branch. Nothing specific for a human to check.
--
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/198#issuecomment-6611695227
You are receiving this because you are subscribed to this thread.
Message ID: <barnowl/barnowl/pull/198/c6611695227@github.com>
----==_mimepart_6aea22917cb82_f312d05846c2
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; alig=
n-items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius=
:50%; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githu=
busercontent.com/u/131936?s=3D20&v=3D4" /><strong>djbclark</strong> l=
eft a comment <a href=3D"https://github.com/barnowl/barnowl/pull/198#issu=
ecomment-6611695227">(barnowl/barnowl#198)</a></div>
<p dir=3D"auto">Testing status: <strong>not done yet.</strong> I ran this=
PR's own tests on master and on the branch, plus a live BarnOwl check wi=
th injected messages (before/after screenshots and logs), but I still nee=
d to review that evidence myself before calling it tested.</p>
<p dir=3D"auto">Findings: the new <code class=3D"notranslate">t/style-bas=
ic.t</code> fails on master (cannot call <code class=3D"notranslate">form=
at_message</code>) and passes on the branch. Live: <code class=3D"notrans=
late">:view -s basic</code> shows <code class=3D"notranslate"><unforma=
tted message></code> and the error "Can't locate object method format_=
message" on master, and renders normally on the branch. Nothing specific =
for a human to check.</p>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/198?email_source=3Dnotifications&email_token=3DABC=
ERSOOCXESZXFR7ZRCTQ35XINBDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW=
2ZLOOQXTMNRRGE3DSNJSGI32M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXE=
X3DNRUWG2Y#issuecomment-6611695227">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ABCERSLSZRZYFH3XSYZRQ3L=
5XINBDAVCNFSNUABCKJSXA33TNF2G64TZHM3TINZTGA4TWSLTON2WKOZWGE3TIMBXGU4DAM5B=
OYBA">unsubscribe</a>.<br />Triage notifications, keep track of coding ag=
ent tasks and review pull requests on the go with GitHub Mobile for <a hr=
ef=3D"https://github.com/notifications/mobile/ios/ABCERSLXGHZLPZXIEW6HOHL=
5XINBDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSNJS=
GI32M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and=
<a href=3D"https://github.com/notifications/mobile/android/ABCERSJD5RNDK=
QFN2KGMA5L5XINBDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMN=
RRGE3DSNJSGI32M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33=
JMQ">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSL2VZJAIRIXX4IWI63=
5XINBDBFCNFSM6AAAAADEDGLQ7OWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3P=
NVWWK3TUL5UWJTYAAAAADCQWOZ52M4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1=
" width=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0;=
display: none; visibility: hidden; overflow: hidden; opacity: 0; width: =
0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <sp=
an><barnowl/barnowl/pull/198/c6611695227</span><span>@</span><span>git=
hub</span><span>.</span><span>com></span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/198?email_source=3Dnot=
ifications\u0026email_token=3DABCERSKXPHI5SEHZO4XV7DD5XINBDA5CNFSNUABFM5U=
WIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSNJSGI32M4TFMFZW63VKON2W=
E43DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6611695227",
"url": "https://github.com/barnowl/barnowl/pull/198?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSKXPHI5SEHZO4XV7DD5XINBDA5CNFSNUABFM5UWIO=
RPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRRGE3DSNJSGI32M4TFMFZW63VKON2WE43=
DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6611695227",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6aea22917cb82_f312d05846c2--
