[4309] in BarnOwl Developers
Re: [barnowl/barnowl] Six small fixes for bugs in master (logging
daemon@ATHENA.MIT.EDU (Daniel JB Clark)
Tue Nov 3 11:45:18 2026
Date: Tue, 03 Nov 2026 08:43:16 -0800
From: Daniel JB Clark <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSJZDLAP5CMPB7LPLUDLMNMSJEVBNHHQAAAAAFXGMU3Z@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/190@github.com>
----==_mimepart_6aea0f244751d_ae12d0140523
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
djbclark left a comment (barnowl/barnowl#190)
Testing status: **not done yet.** I have collected evidence (per-commit before/after screenshots, short GIFs, logs, and live Zephyr/AFS runs) but I still need to review it myself before calling this tested, so please hold off on treating it as tested until I follow up.
Things that could use a human, or that I could not fully test:
1. Alt/Ctrl-Right/Left word motion (the keys.c commit): under `TERM=xterm-256color` the sequences `ESC [ 1 ; 3 C` / `5 C` had no effect on either master or this branch (ncurses appears to decode them as a named key before the editwin bindings see them). Under `TERM=screen`/tmux the new bindings work. Someone with a real xterm, iTerm2 or Terminal.app should check: type `zwrite x`, Ctrl-A, then Alt-Right.
2. The 60-minute default `flush-logs-interval`: I only verified the flush with the interval set to 1 minute (log to AFS, `unlog`, receive a message, `aklog`, wait). I did not wait out the 60-minute default.
3. The duplicate log write fix with a real multi-recipient CC'd personal zephyr from another user: I reproduced it with injected messages only.
4. Natural AFS token expiry rather than `unlog`.
Minor: `:show variable flush-logs-interval` still prints "Default: -1".
--
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/190#issuecomment-6609888577
You are receiving this because you are subscribed to this thread.
Message ID: <barnowl/barnowl/pull/190/c6609888577@github.com>
----==_mimepart_6aea0f244751d_ae12d0140523
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; alig=
n-items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius=
:50%; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githu=
busercontent.com/u/131936?s=3D20&v=3D4" /><strong>djbclark</strong> l=
eft a comment <a href=3D"https://github.com/barnowl/barnowl/pull/190#issu=
ecomment-6609888577">(barnowl/barnowl#190)</a></div>
<p dir=3D"auto">Testing status: <strong>not done yet.</strong> I have col=
lected evidence (per-commit before/after screenshots, short GIFs, logs, a=
nd live Zephyr/AFS runs) but I still need to review it myself before call=
ing this tested, so please hold off on treating it as tested until I foll=
ow up.</p>
<p dir=3D"auto">Things that could use a human, or that I could not fully =
test:</p>
<ol dir=3D"auto">
<li>Alt/Ctrl-Right/Left word motion (the keys.c commit): under <code clas=
s=3D"notranslate">TERM=3Dxterm-256color</code> the sequences <code class=3D=
"notranslate">ESC [ 1 ; 3 C</code> / <code class=3D"notranslate">5 C</cod=
e> had no effect on either master or this branch (ncurses appears to deco=
de them as a named key before the editwin bindings see them). Under <code=
class=3D"notranslate">TERM=3Dscreen</code>/tmux the new bindings work. S=
omeone with a real xterm, iTerm2 or Terminal.app should check: type <code=
class=3D"notranslate">zwrite x</code>, Ctrl-A, then Alt-Right.</li>
<li>The 60-minute default <code class=3D"notranslate">flush-logs-interval=
</code>: I only verified the flush with the interval set to 1 minute (log=
to AFS, <code class=3D"notranslate">unlog</code>, receive a message, <co=
de class=3D"notranslate">aklog</code>, wait). I did not wait out the 60-m=
inute default.</li>
<li>The duplicate log write fix with a real multi-recipient CC'd personal=
zephyr from another user: I reproduced it with injected messages only.</=
li>
<li>Natural AFS token expiry rather than <code class=3D"notranslate">unlo=
g</code>.</li>
</ol>
<p dir=3D"auto">Minor: <code class=3D"notranslate">:show variable flush-l=
ogs-interval</code> still prints "Default: -1".</p>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/190?email_source=3Dnotifications&email_token=3DABC=
ERSI542KLS6EYNWUMUID5XIDKJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW=
2ZLOOQXTMNRQHE4DQOBVG432M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXE=
X3DNRUWG2Y#issuecomment-6609888577">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ABCERSPYGF6PDYFCEFQQA3D=
5XIDKJAVCNFSNUABCKJSXA33TNF2G64TZHM3TINZTGA4TWSLTON2WKOZWGE2DOMJWG4YDSN5B=
OYBA">unsubscribe</a>.<br />Triage notifications, keep track of coding ag=
ent tasks and review pull requests on the go with GitHub Mobile for <a hr=
ef=3D"https://github.com/notifications/mobile/ios/ABCERSIDER3TQSONZ2BGTXT=
5XIDKJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRQHE4DQOBV=
G432M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and=
<a href=3D"https://github.com/notifications/mobile/android/ABCERSPM7KV6Z=
ZMQUYJUYPL5XIDKJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMN=
RQHE4DQOBVG432M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33=
JMQ">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSIL3GGZVRKOVGOOTSL=
5XIDKJBFCNFSM6AAAAADD6IIYOGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3P=
NVWWK3TUL5UWJTYAAAAADCP24VA2M4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1=
" width=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0;=
display: none; visibility: hidden; overflow: hidden; opacity: 0; width: =
0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <sp=
an><barnowl/barnowl/pull/190/c6609888577</span><span>@</span><span>git=
hub</span><span>.</span><span>com></span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/190?email_source=3Dnot=
ifications\u0026email_token=3DABCERSJX5KCFTYVAOJCJCP35XIDKJA5CNFSNUABFM5U=
WIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRQHE4DQOBVG432M4TFMFZW63VKON2W=
E43DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6609888577",
"url": "https://github.com/barnowl/barnowl/pull/190?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSJX5KCFTYVAOJCJCP35XIDKJA5CNFSNUABFM5UWIO=
RPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRQHE4DQOBVG432M4TFMFZW63VKON2WE43=
DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6609888577",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6aea0f244751d_ae12d0140523--
