[4123] in BarnOwl Developers
Re: [barnowl/barnowl] Perl logging (#54)
daemon@ATHENA.MIT.EDU (Jason Gross)
Sun Aug 6 01:34:18 2017
Date: Sun, 06 Aug 2017 05:34:12 +0000 (UTC)
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c9939eb4b80d4baf42778b6a2a2b74121b700785da92cf00000001159e6c5492a169ce00127fe9@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: barnowl-dev email-only account <barnowl-dev@mit.edu>,
Comment <comment@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/54@github.com>
----==_mimepart_5986aa54c02ca_569e3fdca9999c2c1524c9
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
JasonGross commented on this pull request.
> @@ -133,6 +144,14 @@ sub zephyr_cc {
return undef;
}
+sub zephyr_cc_without_recipient {
+ my $self = shift;
+ my $recipient = lc(strip_realm($self->recipient));
+ my $cc = $self->zephyr_cc;
+ return grep { lc(strip_realm($_)) ne $recipient } split(/\s+/, $cc) if defined $cc;
I added
```perl
# Note: This is the cc-line without the recipient; it does not include
# the sender.
```
above the definition of the function; is that sufficient, or did you want something more specific?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/54#discussion_r131534697
----==_mimepart_5986aa54c02ca_569e3fdca9999c2c1524c9
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@JasonGross</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534697">perl/lib/BarnOwl/Message/Zephyr.pm</a>:</p>
<pre style='color:#555'>> @@ -133,6 +144,14 @@ sub zephyr_cc {
return undef;
}
+sub zephyr_cc_without_recipient {
+ my $self = shift;
+ my $recipient = lc(strip_realm($self->recipient));
+ my $cc = $self->zephyr_cc;
+ return grep { lc(strip_realm($_)) ne $recipient } split(/\s+/, $cc) if defined $cc;
</pre>
<p>I added</p>
<div class="highlight highlight-source-perl"><pre><span class="pl-c"><span class="pl-c">#</span> Note: This is the cc-line without the recipient; it does not include</span>
<span class="pl-c"><span class="pl-c">#</span> the sender.</span></pre></div>
<p>above the definition of the function; is that sufficient, or did you want something more specific?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534697">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyflYCbVwdQgLom6M28ao-O2PnKrEks5sVVBUgaJpZM4BW8Zd">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyZ02_dffzuHsIg2IuBQqus2d0h4pks5sVVBUgaJpZM4BW8Zd.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534697"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@JasonGross commented on #54"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/54#discussion_r131534697"}}}</script>
----==_mimepart_5986aa54c02ca_569e3fdca9999c2c1524c9--
