[4122] in BarnOwl Developers
Re: [barnowl/barnowl] Perl logging (#54)
daemon@ATHENA.MIT.EDU (Alex Dehnert)
Sun Aug 6 01:34:00 2017
Date: Sat, 05 Aug 2017 22:33:56 -0700
From: Alex Dehnert <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c91f421335ecb39707d5f4aae67517e41ad5c38c9292cf00000001159e6c4492a169ce00127fe9@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: barnowl-dev email-only account <barnowl-dev@mit.edu>,
Comment <comment@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/54@github.com>
----==_mimepart_5986aa4464d64_f8273fadec07fc2c7486
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
dehnert commented on this pull request.
> @@ -222,5 +241,65 @@ sub replysendercmd {
return $self->replycmd(1);
}
+# Logging
+sub log_header {
+ my ($m) = @_;
+ my $class = $m->class;
+ my $instance = $m->instance;
+ my $opcode = $m->opcode;
+ my $timestr = $m->time;
+ my $host = $m->host;
+ my $sender = $m->pretty_sender;
+ my $zsig = $m->zsig;
+ my $rtn = "Class: $class Instance: $instance";
+ $rtn .= " Opcode: $opcode" unless !defined $opcode || $opcode eq '';
+ $rtn .= "\nTime: $timestr Host: $host"
+ . "\nFrom: $zsig <$sender>";
+ return $rtn;
I got about this far without serious issues. I'm now tired enough that I'm not convinced further review will be reliable to leave me confident saying "LGTM", so I'm stopping for the night.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/54#pullrequestreview-54527659
----==_mimepart_5986aa4464d64_f8273fadec07fc2c7486
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@dehnert</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534691">perl/lib/BarnOwl/Message/Zephyr.pm</a>:</p>
<pre style='color:#555'>> @@ -222,5 +241,65 @@ sub replysendercmd {
return $self->replycmd(1);
}
+# Logging
+sub log_header {
+ my ($m) = @_;
+ my $class = $m->class;
+ my $instance = $m->instance;
+ my $opcode = $m->opcode;
+ my $timestr = $m->time;
+ my $host = $m->host;
+ my $sender = $m->pretty_sender;
+ my $zsig = $m->zsig;
+ my $rtn = "Class: $class Instance: $instance";
+ $rtn .= " Opcode: $opcode" unless !defined $opcode || $opcode eq '';
+ $rtn .= "\nTime: $timestr Host: $host"
+ . "\nFrom: $zsig <$sender>";
+ return $rtn;
</pre>
<p>I got about this far without serious issues. I'm now tired enough that I'm not convinced further review will be reliable to leave me confident saying "LGTM", so I'm stopping for the night.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/54#pullrequestreview-54527659">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyRjQ7y0096yZoXNNxdgvyWxEj3irks5sVVBEgaJpZM4BW8Zd">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyV84D7fMMoA8t88noxiTfOUMB50kks5sVVBEgaJpZM4BW8Zd.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/54#pullrequestreview-54527659"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@dehnert commented on #54"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/54#pullrequestreview-54527659"}}}</script>
----==_mimepart_5986aa4464d64_f8273fadec07fc2c7486--
