[4116] in BarnOwl Developers
Re: [barnowl/barnowl] Perl logging (#54)
daemon@ATHENA.MIT.EDU (Jason Gross)
Sun Aug 6 01:19:34 2017
Date: Sun, 06 Aug 2017 05:19:28 +0000 (UTC)
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c90babc1974d2cc210a28296e9c1b7d40673ceffa292cf00000001159e68df92a169ce00127fe9@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: barnowl-dev email-only account <barnowl-dev@mit.edu>,
Comment <comment@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/54@github.com>
----==_mimepart_5986a6dfad52c_371e3fef6a92fc2c513c9
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
JasonGross commented on this pull request.
> + {
+ default => '',
+ summary => 'name of a filter controlling which messages to log',
+ description => "If non empty, any messages matching the given filter will be logged.\n"
+ . "This is a completely separate mechanism from the other logging\n"
+ . "variables like logging, classlogging, loglogins, loggingdirection,\n"
+ . "etc. If you want this variable to control all logging, make sure\n"
+ . "all other logging variables are in their default state."
+ });
+
+ BarnOwl::new_variable_bool('loglogins',
+ {
+ default => 0,
+ summary => 'enable logging of login notifications',
+ description => "When this is enabled, BarnOwl will log login and logout notifications\n"
+ . "for AIM, zephyr, or other protocols. If disabled BarnOwl will not print\n"
Changed "print" to "log"
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/54#discussion_r131534556
----==_mimepart_5986a6dfad52c_371e3fef6a92fc2c513c9
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@JasonGross</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534556">perl/lib/BarnOwl/Logging.pm</a>:</p>
<pre style='color:#555'>> + {
+ default => '',
+ summary => 'name of a filter controlling which messages to log',
+ description => "If non empty, any messages matching the given filter will be logged.\n"
+ . "This is a completely separate mechanism from the other logging\n"
+ . "variables like logging, classlogging, loglogins, loggingdirection,\n"
+ . "etc. If you want this variable to control all logging, make sure\n"
+ . "all other logging variables are in their default state."
+ });
+
+ BarnOwl::new_variable_bool('loglogins',
+ {
+ default => 0,
+ summary => 'enable logging of login notifications',
+ description => "When this is enabled, BarnOwl will log login and logout notifications\n"
+ . "for AIM, zephyr, or other protocols. If disabled BarnOwl will not print\n"
</pre>
<p>Changed "print" to "log"</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534556">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyU2Or3nM9rmqB1U28nAEuLqY94vnks5sVUzfgaJpZM4BW8Zd">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyU4QIrqZ17xRB1MU3BVRLsSnybe9ks5sVUzfgaJpZM4BW8Zd.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534556"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@JasonGross commented on #54"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/54#discussion_r131534556"}}}</script>
----==_mimepart_5986a6dfad52c_371e3fef6a92fc2c513c9--
