[4115] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

Re: [barnowl/barnowl] Perl logging (#54)

daemon@ATHENA.MIT.EDU (Jason Gross)
Sun Aug 6 01:19:14 2017

Date: Sat, 05 Aug 2017 22:19:10 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c95ea4eda7c39d7bd53db4f9b76dc1e4dc416ce91692cf00000001159e68ce92a169ce00127fe9@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: barnowl-dev email-only account <barnowl-dev@mit.edu>,
        Comment <comment@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/54@github.com>


----==_mimepart_5986a6ce22d1c_639f3fa578401c3c1059e3
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

JasonGross commented on this pull request.



> +        });
+
+    BarnOwl::new_variable_enum('loggingdirection',
+        {
+            default       => 'both',
+            validsettings => [qw(in out both)],
+            summary       => "specifies which kind of messages should be logged",
+            description   => "Can be one of 'both', 'in', or 'out'.  If 'in' is\n"
+                           . "selected, only incoming messages are logged, if 'out'\n"
+                           . "is selected only outgoing messages are logged.  If 'both'\n"
+                           . "is selected both incoming and outgoing messages are\n"
+                           . "logged.\n\n"
+                           . "Note that this variable applies to all messages. In\n"
+                           . "particular, if this variable is set to 'out', the\n"
+                           . "classlogging variable will have no effect, and no\n"
+                           . "class messages will be logged."

Done

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/54#discussion_r131534554
----==_mimepart_5986a6ce22d1c_639f3fa578401c3c1059e3
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@JasonGross</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534554">perl/lib/BarnOwl/Logging.pm</a>:</p>
<pre style='color:#555'>&gt; +        });
+
+    BarnOwl::new_variable_enum(&#39;loggingdirection&#39;,
+        {
+            default       =&gt; &#39;both&#39;,
+            validsettings =&gt; [qw(in out both)],
+            summary       =&gt; &quot;specifies which kind of messages should be logged&quot;,
+            description   =&gt; &quot;Can be one of &#39;both&#39;, &#39;in&#39;, or &#39;out&#39;.  If &#39;in&#39; is\n&quot;
+                           . &quot;selected, only incoming messages are logged, if &#39;out&#39;\n&quot;
+                           . &quot;is selected only outgoing messages are logged.  If &#39;both&#39;\n&quot;
+                           . &quot;is selected both incoming and outgoing messages are\n&quot;
+                           . &quot;logged.\n\n&quot;
+                           . &quot;Note that this variable applies to all messages. In\n&quot;
+                           . &quot;particular, if this variable is set to &#39;out&#39;, the\n&quot;
+                           . &quot;classlogging variable will have no effect, and no\n&quot;
+                           . &quot;class messages will be logged.&quot;
</pre>
<p>Done</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534554">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyWOXrHnfr-oG-uAfuZ4G-jck0rsOks5sVUzOgaJpZM4BW8Zd">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIydvK5AyhXzaSX7eEEhH6vZEZtvoCks5sVUzOgaJpZM4BW8Zd.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534554"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@JasonGross commented on #54"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/54#discussion_r131534554"}}}</script>
----==_mimepart_5986a6ce22d1c_639f3fa578401c3c1059e3--

home help back first fref pref prev next nref lref last post