[4092] in BarnOwl Developers
Re: [barnowl/barnowl] Defer failed log messages (#109)
daemon@ATHENA.MIT.EDU (Jason Gross)
Sat Aug 5 20:55:13 2017
Date: Sat, 05 Aug 2017 17:55:11 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c9187a49b662c214860302cda96f540233139a00d392cf00000001159e2aef92a169ce009427d1@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/109@github.com>
----==_mimepart_598668efd8cac_678e3f9364f77c2c2051e
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
JasonGross commented on this pull request.
> @@ -180,13 +226,108 @@ static void owl_log_entry_free(void *data)
}
}
+#if GLIB_CHECK_VERSION(2, 32, 0)
I've reported a [ticket on trac](https://barnowl.mit.edu/ticket/293#ticket) to note that we should do this in a follow-up PR (and in more places than just the two in this file).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/109#discussion_r131532273
----==_mimepart_598668efd8cac_678e3f9364f77c2c2051e
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@JasonGross</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/109#discussion_r131532273">logging.c</a>:</p>
<pre style='color:#555'>> @@ -180,13 +226,108 @@ static void owl_log_entry_free(void *data)
}
}
+#if GLIB_CHECK_VERSION(2, 32, 0)
</pre>
<p>I've reported a <a href="https://barnowl.mit.edu/ticket/293#ticket">ticket on trac</a> to note that we should do this in a follow-up PR (and in more places than just the two in this file).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/109#discussion_r131532273">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyeskNfbdeCu_6754zXpHtlb2vXl8ks5sVQ7vgaJpZM4AWArI">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyTej8uR3gWyYwL6YTxleKS7_c6iEks5sVQ7vgaJpZM4AWArI.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/109#discussion_r131532273"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@JasonGross commented on #109"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/109#discussion_r131532273"}}}</script>
----==_mimepart_598668efd8cac_678e3f9364f77c2c2051e--
