[4091] in BarnOwl Developers
Re: [barnowl/barnowl] Defer failed log messages (#109)
daemon@ATHENA.MIT.EDU (Alex Dehnert)
Sat Aug 5 20:49:44 2017
Date: Sun, 06 Aug 2017 00:49:42 +0000 (UTC)
From: Alex Dehnert <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c95adf7d841fdf738e6a66427cd4408f3aa6c50b9492cf00000001159e29a692a169ce009427d1@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/109@github.com>
----==_mimepart_598667a653895_125d3fa9cc7b5c2c94519
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
adehnert commented on this pull request.
> @@ -180,13 +226,108 @@ static void owl_log_entry_free(void *data)
}
}
+#if GLIB_CHECK_VERSION(2, 32, 0)
I think that a reasonable rule of thumb for version support[1] is "Do all supported versions of Ubuntu and Debian include a new enough version?", which this appears to satisfy: Wheezy has 2.32 (I think) (https://packages.debian.org/wheezy/libglib2.0-0) and Trusty has 2.40 (https://packages.ubuntu.com/trusty/libglib2.0-0). You don't need to remove the <2.32 support, but you can if you want to in a follow-on PR.
[1] I think we can be stricter -- I wouldn't be opposed to "dialups and the most recent Debian and Ubuntu LTS versions at least six months old", or something -- but this definitely seems fine. I guess I'm potentially open to an RHEL requirement too.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/109#pullrequestreview-54525255
----==_mimepart_598667a653895_125d3fa9cc7b5c2c94519
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@adehnert</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/109#discussion_r131532225">logging.c</a>:</p>
<pre style='color:#555'>> @@ -180,13 +226,108 @@ static void owl_log_entry_free(void *data)
}
}
+#if GLIB_CHECK_VERSION(2, 32, 0)
</pre>
<p>I think that a reasonable rule of thumb for version support[1] is "Do all supported versions of Ubuntu and Debian include a new enough version?", which this appears to satisfy: Wheezy has 2.32 (I think) (<a href="https://packages.debian.org/wheezy/libglib2.0-0">https://packages.debian.org/wheezy/libglib2.0-0</a>) and Trusty has 2.40 (<a href="https://packages.ubuntu.com/trusty/libglib2.0-0">https://packages.ubuntu.com/trusty/libglib2.0-0</a>). You don't need to remove the <2.32 support, but you can if you want to in a follow-on PR.</p>
<p>[1] I think we can be stricter -- I wouldn't be opposed to "dialups and the most recent Debian and Ubuntu LTS versions at least six months old", or something -- but this definitely seems fine. I guess I'm potentially open to an RHEL requirement too.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/109#pullrequestreview-54525255">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyfrxWhmpeDgl6W--blsgovvvcRDlks5sVQ2mgaJpZM4AWArI">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIySkfVRmgjj_EXtTpE6Y7ZgjggJJyks5sVQ2mgaJpZM4AWArI.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/109#pullrequestreview-54525255"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adehnert commented on #109"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/109#pullrequestreview-54525255"}}}</script>
----==_mimepart_598667a653895_125d3fa9cc7b5c2c94519--
