[3950] in BarnOwl Developers
Re: [barnowl] rewrite zephyr scribelike markup parsing (#172)
daemon@ATHENA.MIT.EDU (Karl Ramm)
Mon Mar 21 22:46:21 2016
Date: Mon, 21 Mar 2016 19:46:17 -0700
From: Karl Ramm <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c9a1b09fa3e3e4ce7d16d1fb976df0b276eb0abbf892cf00000001130873f992a169ce0868a710@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/172@github.com>
----==_mimepart_56f0b1f9d93cc_298b3f94a4f8b2b814749c3
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
I have not, because it hadn't occurred to me, at least partially because I can reason about my code's time complexity (it was written to be O(n) time on the size of the input) and I can't duplicate the reasoning about the original code.
(Also strpbrk is doing the same sort of table lookup (albeit in assembly language) and bulding the (admittedly simpler) table on every call.)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/172#issuecomment-199601475
----==_mimepart_56f0b1f9d93cc_298b3f94a4f8b2b814749c3
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p>I have not, because it hadn't occurred to me, at least partially because I can reason about my code's time complexity (it was written to be O(n) time on the size of the input) and I can't duplicate the reasoning about the original code.</p>
<p>(Also strpbrk is doing the same sort of table lookup (albeit in assembly language) and bulding the (admittedly simpler) table on every call.)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/barnowl/barnowl/pull/172#issuecomment-199601475">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AERIySZJm_QqKZ2a6jZe_43ZFr540G6sks5pv1f5gaJpZM4HxXeZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/172#issuecomment-199601475"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
----==_mimepart_56f0b1f9d93cc_298b3f94a4f8b2b814749c3--