[3949] in BarnOwl Developers
Re: [barnowl] rewrite zephyr scribelike markup parsing (#172)
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Mon Mar 21 19:45:14 2016
Date: Mon, 21 Mar 2016 16:45:08 -0700
From: Anders Kaseorg <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c9db15d1fe2f8392e2693e61fd4a71b93da179e56192cf000000011308498492a169ce0868a710@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/172@github.com>
----==_mimepart_56f08784e159f_66363fb4098c32bc610562
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
This code is on the critical path for `search`, so I worry a little about the performance implications of replacing a `strpbrk`-based parser with something that does table lookups and opcode interpretation on every character. Have you benchmarked it?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/172#issuecomment-199539303
----==_mimepart_56f08784e159f_66363fb4098c32bc610562
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p>This code is on the critical path for <code>search</code>, so I worry a little about the performance implications of replacing a <code>strpbrk</code>-based parser with something that does table lookups and opcode interpretation on every character. Have you benchmarked it?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/barnowl/barnowl/pull/172#issuecomment-199539303">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AERIye9w6A3qPY8oKCbS62d-0CwDF3PLks5pvy2EgaJpZM4HxXeZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/172#issuecomment-199539303"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
----==_mimepart_56f08784e159f_66363fb4098c32bc610562--
