[3690] in BarnOwl Developers

home	help	back	first	fref	pref	prev	next	nref	lref	last	post

Re: [barnowl] Perl logging (#54)

daemon@ATHENA.MIT.EDU (Jason Gross)
Sat Jan 4 13:59:20 2014

Date: Sat, 04 Jan 2014 10:59:16 -0800
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+p-8652640-373fae6d45acb8a832d644bf4ab4a7d0d6156a3f-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: barnowl-dev email-only account <barnowl-dev@mit.edu>
In-Reply-To: <barnowl/barnowl/pull/54@github.com>


----==_mimepart_52c85a046dd5e_2130601d001346af
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

> @@ -22,6 +22,12 @@ sub principal_realm {
>      return $realm;
>  }
>  
> +sub casefold_principal {
> +    my $principal = shift;
> +    my ($user, $realm) = split(/@/, $principal);

Fixed.  I've also added tests, to test this method.  I'm not sure that I picked a very good file name for the tests...

---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/54/files#r8652640
----==_mimepart_52c85a046dd5e_2130601d001346af
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>In perl/lib/BarnOwl/Message/Zephyr.pm:</p>
<pre style='color:#555'>&gt; @@ -22,6 +22,12 @@ sub principal_realm {
&gt;      return $realm;
&gt;  }
&gt;  
&gt; +sub casefold_principal {
&gt; +    my $principal = shift;
&gt; +    my ($user, $realm) = split(/@/, $principal);
</pre>
<p>Fixed.  I've also added tests, to test this method.  I'm not sure that I picked a very good file name for the tests...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href='https://github.com/barnowl/barnowl/pull/54/files#r8652640'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/4475081__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNDM5NDc1NiwiZGF0YSI6eyJpZCI6MjI3OTE3NzN9fQ==--6a32374bceb2f734cf0efd3a12b2ed740c80d8a9.gif' height='1' width='1'></p>
----==_mimepart_52c85a046dd5e_2130601d001346af--

home	help	back	first	fref	pref	prev	next	nref	lref	last	post