[3689] in BarnOwl Developers

home	help	back	first	fref	pref	prev	next	nref	lref	last	post

Re: [barnowl] Perl logging (#54)

daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Sat Jan 4 06:07:16 2014

Date: Sat, 04 Jan 2014 03:07:13 -0800
From: Anders Kaseorg <notifications@github.com>
Reply-To: barnowl/barnowl <reply+p-8651464-bc8bce3e2e9fa35ca9bc5834c610a5e41dd62311-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/54@github.com>


----==_mimepart_52c7eb60f3f6b_1e381421d048479b
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

> @@ -22,6 +22,12 @@ sub principal_realm {
>      return $realm;
>  }
>  
> +sub casefold_principal {
> +    my $principal = shift;
> +    my ($user, $realm) = split(/@/, $principal);

That probably does the wrong thing if the realm is missing, and still explodes on the empty string.

---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/54/files#r8651464
----==_mimepart_52c7eb60f3f6b_1e381421d048479b
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>In perl/lib/BarnOwl/Message/Zephyr.pm:</p>
<pre style='color:#555'>&gt; @@ -22,6 +22,12 @@ sub principal_realm {
&gt;      return $realm;
&gt;  }
&gt;  
&gt; +sub casefold_principal {
&gt; +    my $principal = shift;
&gt; +    my ($user, $realm) = split(/@/, $principal);
</pre>
<p>That probably does the wrong thing if the realm is missing, and still explodes on the empty string.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href='https://github.com/barnowl/barnowl/pull/54/files#r8651464'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/4475081__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNDM2NjQzMiwiZGF0YSI6eyJpZCI6MjI3OTE3NzN9fQ==--72db25534b1f66093cbc0938f576ed05aefa1bf6.gif' height='1' width='1'></p>
----==_mimepart_52c7eb60f3f6b_1e381421d048479b--

home	help	back	first	fref	pref	prev	next	nref	lref	last	post