[3470] in BarnOwl Developers
[barnowl] Refactor perlconfig (#140)
daemon@ATHENA.MIT.EDU (Jason Gross)
Sun Jun 9 13:25:37 2013
Date: Sun, 09 Jun 2013 10:25:29 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-15322991-87ad6b5cc00317b4e1dcab3fc62115311ab58e62-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
----==_mimepart_51b4ba8948f21_dd3470bdcc451fd
Date: Sun, 09 Jun 2013 10:25:29 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51b4ba894abb0_dd3470bdcc45264@github-worker7-cp1-prd.iad.github.net.mail>
This is the chunk of code in idle/away hooks (https://github.com/barnowl/barnowl/pull/49) which I have no significant basis for thinking is reasonable, and on which I've not recieved any comments since I've asked about it two years ago (other than that it compiles and doesn't seem to break anything). Now that we have the updated code review policy, I figure I'll post this to the mailing list, and merge it in a week or two if no-one comments on it.
The two outcomes of these commits are:
* there's support for calling perl methods and interpreting the return value as a boolean or integer
* error messages on malformed calls of perl methods are more consistent
I need the first of these to move "away" logic into perl, and query it from C.
You can merge this Pull Request by running:
git pull https://github.com/JasonGross/barnowl refactor-perlconfig
Or you can view, comment on it, or merge it online at:
https://github.com/barnowl/barnowl/pull/140
-- Commit Summary --
* Added support for calling perl subs with various return types
* Refactor perl calls through a single method
-- File Changes --
M owl_perl.h (95)
M perlconfig.c (305)
M style.c (33)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/140.patch
https://github.com/barnowl/barnowl/pull/140.diff
----==_mimepart_51b4ba8948f21_dd3470bdcc451fd
Date: Sun, 09 Jun 2013 10:25:29 -0700
Mime-Version: 1.0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51b4ba894b46f_dd3470bdcc453da@github-worker7-cp1-prd.iad.github.net.mail>
<p>This is the chunk of code in idle/away hooks (<a href="https://github.com/barnowl/barnowl/issues/49" class="issue-link" title="Idle/away hooks in perl">#49</a>) which I have no significant basis for thinking is reasonable, and on which I've not recieved any comments since I've asked about it two years ago (other than that it compiles and doesn't seem to break anything). Now that we have the updated code review policy, I figure I'll post this to the mailing list, and merge it in a week or two if no-one comments on it.</p>
<p>The two outcomes of these commits are:</p>
<ul>
<li>there's support for calling perl methods and interpreting the return value as a boolean or integer</li>
<li>error messages on malformed calls of perl methods are more consistent</li>
</ul><p>I need the first of these to move "away" logic into perl, and query it from C.</p>
<hr>
<h4>You can merge this Pull Request by running</h4>
<pre> git pull https://github.com/JasonGross/barnowl refactor-perlconfig</pre>
<p>Or view, comment on, or merge it at:</p>
<p> <a href='https://github.com/barnowl/barnowl/pull/140'>https://github.com/barnowl/barnowl/pull/140</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Added support for calling perl subs with various return types</li>
<li>Refactor perl calls through a single method</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/140/files#diff-0">owl_perl.h</a>
(95)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/140/files#diff-1">perlconfig.c</a>
(305)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/140/files#diff-2">style.c</a>
(33)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/barnowl/barnowl/pull/140.patch'>https://github.com/barnowl/barnowl/pull/140.patch</a></li>
<li><a href='https://github.com/barnowl/barnowl/pull/140.diff'>https://github.com/barnowl/barnowl/pull/140.diff</a></li>
</ul>
----==_mimepart_51b4ba8948f21_dd3470bdcc451fd--
