[3459] in BarnOwl Developers
[barnowl] Restore variable behavior on module reload (#139)
daemon@ATHENA.MIT.EDU (David Benjamin)
Tue Jun 4 19:56:09 2013
Date: Tue, 04 Jun 2013 16:56:05 -0700
From: David Benjamin <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-15147578-52e8413f2fb9ccf06b2227a17fafd845a596f0b4-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
----==_mimepart_51ae7e95b9085_1e2b749dd461895
Date: Tue, 04 Jun 2013 16:56:05 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51ae7e95bb030_1e2b749dd46195a@worker1.rs.github.com.mail>
This contains pull request #138.
You can merge this Pull Request by running:
git pull https://github.com/davidben/barnowl variable-reload
Or you can view, comment on it, or merge it online at:
https://github.com/barnowl/barnowl/pull/139
-- Commit Summary --
* Add tests to detect new_variable_* overriding previously set values
* Merge remote branch 'rnjacobs/master'
* Make the fullvar variable test more reasonable
* Don't g_value_unset an uninitialized GValue
* When replacing a variable, keep the old value
-- File Changes --
M t/variable.t (42)
M variable.c (14)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/139.patch
https://github.com/barnowl/barnowl/pull/139.diff
----==_mimepart_51ae7e95b9085_1e2b749dd461895
Date: Tue, 04 Jun 2013 16:56:05 -0700
Mime-Version: 1.0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51ae7e95bbb5c_1e2b749dd4620b4@worker1.rs.github.com.mail>
<p>This contains pull request <a href="https://github.com/barnowl/barnowl/issues/138" class="issue-link" title="new_variable_* reinit">#138</a>.</p>
<hr>
<h4>You can merge this Pull Request by running</h4>
<pre> git pull https://github.com/davidben/barnowl variable-reload</pre>
<p>Or view, comment on, or merge it at:</p>
<p> <a href='https://github.com/barnowl/barnowl/pull/139'>https://github.com/barnowl/barnowl/pull/139</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add tests to detect new_variable_* overriding previously set values</li>
<li>Merge remote branch 'rnjacobs/master'</li>
<li>Make the fullvar variable test more reasonable</li>
<li>Don't g_value_unset an uninitialized GValue</li>
<li>When replacing a variable, keep the old value</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/139/files#diff-0">t/variable.t</a>
(42)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/139/files#diff-1">variable.c</a>
(14)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/barnowl/barnowl/pull/139.patch'>https://github.com/barnowl/barnowl/pull/139.patch</a></li>
<li><a href='https://github.com/barnowl/barnowl/pull/139.diff'>https://github.com/barnowl/barnowl/pull/139.diff</a></li>
</ul>
----==_mimepart_51ae7e95b9085_1e2b749dd461895--
