[3458] in BarnOwl Developers
[barnowl] new_variable_* reinit (#138)
daemon@ATHENA.MIT.EDU (Robert Jacobs)
Tue Jun 4 19:24:18 2013
Date: Tue, 04 Jun 2013 16:24:07 -0700
From: Robert Jacobs <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-15146709-31e512cb6a5aef9d44d3abbc839c26be14236cf9-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
----==_mimepart_51ae771757db8_697f1129de0886fa
Date: Tue, 04 Jun 2013 16:24:07 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51ae771759ec0_697f1129de0887dd@worker3.rs.github.com.mail>
perlvariables accidently changed the way new_variable_* works (and overrides any currently set variable). This commit adds tests to detect that.
You can merge this Pull Request by running:
git pull https://github.com/rnjacobs/barnowl master
Or you can view, comment on it, or merge it online at:
https://github.com/barnowl/barnowl/pull/138
-- Commit Summary --
* Add tests to detect new_variable_* overriding previously set values
-- File Changes --
M t/variable.t (20)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/138.patch
https://github.com/barnowl/barnowl/pull/138.diff
----==_mimepart_51ae771757db8_697f1129de0886fa
Date: Tue, 04 Jun 2013 16:24:07 -0700
Mime-Version: 1.0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51ae77175aaf2_697f1129de088854@worker3.rs.github.com.mail>
<p>perlvariables accidently changed the way new_variable_* works (and overrides any currently set variable). This commit adds tests to detect that.</p>
<hr>
<h4>You can merge this Pull Request by running</h4>
<pre> git pull https://github.com/rnjacobs/barnowl master</pre>
<p>Or view, comment on, or merge it at:</p>
<p> <a href='https://github.com/barnowl/barnowl/pull/138'>https://github.com/barnowl/barnowl/pull/138</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add tests to detect new_variable_* overriding previously set values</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/138/files#diff-0">t/variable.t</a>
(20)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/barnowl/barnowl/pull/138.patch'>https://github.com/barnowl/barnowl/pull/138.patch</a></li>
<li><a href='https://github.com/barnowl/barnowl/pull/138.diff'>https://github.com/barnowl/barnowl/pull/138.diff</a></li>
</ul>
----==_mimepart_51ae771757db8_697f1129de0886fa--
