[3452] in BarnOwl Developers
Re: [barnowl] Revamp set/unset completion (#121)
daemon@ATHENA.MIT.EDU (Jason Gross)
Mon May 27 19:25:54 2013
Date: Mon, 27 May 2013 16:25:46 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-11386253-e0867f26ea6e71b09c02fd7b9bcdefb9fbf8a2f0-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/121@github.com>
----==_mimepart_51a3eb7acae4c_1e7e69fdd49373
Date: Mon, 27 May 2013 16:25:46 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51a3eb7accc7f_1e7e69fdd4948d@worker5.rs.github.com.mail>
I've made a commit that documents "get_variable_info" in BarnOwl.pm, and adds it to EXPORT_OK, at https://github.com/JasonGross/barnowl/tree/set-completion (4f37f053363be56e98a255c55712589cb299abc1). If you include this commit, or some roughly equivalent documentation, then LGTM.
(I feel like I was overly nit-picky on this pull request. Sorry.)
---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/121#issuecomment-18517964
----==_mimepart_51a3eb7acae4c_1e7e69fdd49373
Date: Mon, 27 May 2013 16:25:46 -0700
Mime-Version: 1.0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51a3eb7acd68f_1e7e69fdd495b9@worker5.rs.github.com.mail>
<p>I've made a commit that documents "get_variable_info" in BarnOwl.pm, and adds it to EXPORT_OK, at <a href="https://github.com/JasonGross/barnowl/tree/set-completion">https://github.com/JasonGross/barnowl/tree/set-completion</a> (<a href="https://github.com/barnowl/barnowl/commit/4f37f053363be56e98a255c55712589cb299abc1" class="commit-link"><tt>4f37f05</tt></a>). If you include this commit, or some roughly equivalent documentation, then LGTM.</p>
<p>(I feel like I was overly nit-picky on this pull request. Sorry.)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href='https://github.com/barnowl/barnowl/pull/121#issuecomment-18517964'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/JJk3yKd0u6qAmPAmJXdf97W81NjwRQXIIqKLNN-5SiO7b_SGPsstLzqpV-8Mv4dt.gif' height='1' width='1'></p>
----==_mimepart_51a3eb7acae4c_1e7e69fdd49373--
