[3451] in BarnOwl Developers
Re: [barnowl] IRC reconnect (#108)
daemon@ATHENA.MIT.EDU (Jason Gross)
Mon May 27 17:54:10 2013
Date: Mon, 27 May 2013 14:54:07 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-9709132-2001beb80c08e30b034e487c72b5d6a5a38438fb-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/108@github.com>
----==_mimepart_51a3d5ff6a0ed_23aa1203dd889466
Date: Mon, 27 May 2013 14:54:07 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51a3d5ff6c106_23aa1203dd8895b0@worker3.rs.github.com.mail>
I've updated the code to use `grep` rather than `exists`. I've also put `owl_util_file_delete_line` back into perl, because I realized your comment only applied to the add-unique-line function, and also because `owl_util_file_delete_line` creates a backup and dereferences symlinks appropriately.
---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/108#issuecomment-18516057
----==_mimepart_51a3d5ff6a0ed_23aa1203dd889466
Date: Mon, 27 May 2013 14:54:07 -0700
Mime-Version: 1.0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51a3d5ff6cbeb_23aa1203dd88969b@worker3.rs.github.com.mail>
<p>I've updated the code to use <code>grep</code> rather than <code>exists</code>. I've also put <code>owl_util_file_delete_line</code> back into perl, because I realized your comment only applied to the add-unique-line function, and also because <code>owl_util_file_delete_line</code> creates a backup and dereferences symlinks appropriately.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href='https://github.com/barnowl/barnowl/pull/108#issuecomment-18516057'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/JJk3yKd0u6qAmPAmJXdf9_gRuUTQCipO-dP0x97pmbFICXxk9_eKsAFlYwLIF2Vi.gif' height='1' width='1'></p>
----==_mimepart_51a3d5ff6a0ed_23aa1203dd889466--
