[3316] in BarnOwl Developers
Re: [barnowl/barnowl] f809ca: Defer failed log messages
daemon@ATHENA.MIT.EDU (Jason Gross)
Sat Jan 5 15:39:55 2013
In-Reply-To: <50e88ed636673_386d1343af4916b8@sh3.rs.github.com.mail>
From: Jason Gross <jgross@MIT.EDU>
Date: Sat, 5 Jan 2013 15:39:23 -0500
To: barnowl-dev@mit.edu
--14dae9340dfb2989ef04d29099da
Content-Type: text/plain; charset=ISO-8859-1
Sorry about this. I'm undoing it now. I accidentally ran a script I
didn't mean to run, which pushed to upstream instead of master.
-Jason
On Sat, Jan 5, 2013 at 3:36 PM, GitHub <noreply@github.com> wrote:
> Branch: refs/heads/master
> Home: https://github.com/barnowl/barnowl
> Commit: f809cadc174962e158513b239f10be3d55d5b588
>
> https://github.com/barnowl/barnowl/commit/f809cadc174962e158513b239f10be3d55d5b588
> Author: Jason Gross <jgross@mit.edu>
> Date: 2013-01-05 (Sat, 05 Jan 2013)
>
> Changed paths:
> M commands.c
> M logging.c
>
> Log Message:
> -----------
> Defer failed log messages
>
> Previously, when we failed to open a logging file, we errored, and
> dropped the log message. This commit makes it so that, if the reason we
> failed was a permissions error, we instead add the log entry to a queue
> of messages to be logged eventually, and inform the user that logging
> has been suspended. The user must run :flush-logs to resume logging.
>
> If :flush-log has an fopen that fails with EPERM or EACCES, we re-defer
> messages and inform the user.
>
> On shutdown, BarnOwl will attempt to log all messages currently in the
> queue one last time.
>
>
>
>
--14dae9340dfb2989ef04d29099da
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Sorry about this. =A0I'm undoing it now. =A0I accidentally ran a script=
I didn't mean to run, which pushed to upstream instead of master.<div>=
<br></div><div>-Jason<br><br><div class=3D"gmail_quote">On Sat, Jan 5, 2013=
at 3:36 PM, GitHub <span dir=3D"ltr"><<a href=3D"mailto:noreply@github.=
com" target=3D"_blank">noreply@github.com</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">=A0 Branch: refs/heads/master<br>
=A0 Home: =A0 <a href=3D"https://github.com/barnowl/barnowl" target=3D"_bla=
nk">https://github.com/barnowl/barnowl</a><br>
=A0 Commit: f809cadc174962e158513b239f10be3d55d5b588<br>
=A0 =A0 =A0 <a href=3D"https://github.com/barnowl/barnowl/commit/f809cadc17=
4962e158513b239f10be3d55d5b588" target=3D"_blank">https://github.com/barnow=
l/barnowl/commit/f809cadc174962e158513b239f10be3d55d5b588</a><br>
=A0 Author: Jason Gross <<a href=3D"mailto:jgross@mit.edu" target=3D"_bl=
ank">jgross@mit.edu</a>><br>
=A0 Date: =A0 2013-01-05 (Sat, 05 Jan 2013)<br>
<br>
=A0 Changed paths:<br>
=A0 =A0 M commands.c<br>
=A0 =A0 M logging.c<br>
<br>
=A0 Log Message:<br>
=A0 -----------<br>
=A0 Defer failed log messages<br>
<br>
Previously, when we failed to open a logging file, we errored, and<br>
dropped the log message. =A0This commit makes it so that, if the reason we<=
br>
failed was a permissions error, we instead add the log entry to a queue<br>
of messages to be logged eventually, and inform the user that logging<br>
has been suspended. =A0The user must run :flush-logs to resume logging.<br>
<br>
If :flush-log has an fopen that fails with EPERM or EACCES, we re-defer<br>
messages and inform the user.<br>
<br>
On shutdown, BarnOwl will attempt to log all messages currently in the<br>
queue one last time.<br>
<br>
<br>
<br>
</blockquote></div><br></div>
--14dae9340dfb2989ef04d29099da--
