[3315] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] f809ca: Defer failed log messages

daemon@ATHENA.MIT.EDU (GitHub)
Sat Jan 5 15:36:41 2013

Date: Sat, 05 Jan 2013 12:36:38 -0800
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu



----==_mimepart_50e88ed6342a0_386d1343af491453
Date: Sat, 05 Jan 2013 12:36:38 -0800
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <50e88ed6355c8_386d1343af491522@sh3.rs.github.com.mail>

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl
  Commit: f809cadc174962e158513b239f10be3d55d5b588
      https://github.com/barnowl/barnowl/commit/f809cadc174962e158513b239f10be3d55d5b588
  Author: Jason Gross <jgross@mit.edu>
  Date:   2013-01-05 (Sat, 05 Jan 2013)

  Changed paths:
    M commands.c
    M logging.c

  Log Message:
  -----------
  Defer failed log messages

Previously, when we failed to open a logging file, we errored, and
dropped the log message.  This commit makes it so that, if the reason we
failed was a permissions error, we instead add the log entry to a queue
of messages to be logged eventually, and inform the user that logging
has been suspended.  The user must run :flush-logs to resume logging.

If :flush-log has an fopen that fails with EPERM or EACCES, we re-defer
messages and inform the user.

On shutdown, BarnOwl will attempt to log all messages currently in the
queue one last time.




----==_mimepart_50e88ed6342a0_386d1343af491453--

home help back first fref pref prev next nref lref last post