[3256] in BarnOwl Developers
[barnowl/barnowl] 4a80a1: Fix hang on empty zcrypt messages
daemon@ATHENA.MIT.EDU (GitHub)
Wed Mar 14 12:48:21 2012
Date: Wed, 14 Mar 2012 09:48:19 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu
----==_mimepart_4f60cbd3aa759_47fa3ff698f592f81243ce
Date: Wed, 14 Mar 2012 09:48:19 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-ID: <4f60cbd3ac17a_47fa3ff698f592f812446b@sh1.rs.github.com.mail>
Branch: refs/heads/release-1.8
Home: https://github.com/barnowl/barnowl
Commit: 4a80a1673a21bc8f38c8f6ec24420f5bbf5a4f6c
https://github.com/barnowl/barnowl/commit/4a80a1673a21bc8f38c8f6ec2=
4420f5bbf5a4f6c
Author: Alex Dehnert <adehnert@MIT.EDU>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M filterproc.c
Log Message:
-----------
Fix hang on empty zcrypt messages
send_receive will never close wfd if out is an empty string.
Consequently, the zcrypt end will keep waiting for something
to encrypt (or decrypt), thereby deadlocking the barnowl.
This closes wfd if we aren't going to write anything to it.
Consequently, zcrypt will terminate quickly, and we'll also
return.
This fixes a deadlock when sending (at least it's the user's
fault) or receiving (this one is a DoS possibility) empty zcrypted
messages.
Commit: 34132f77bccfca7aad71c3e717edfdb1fec5e748
https://github.com/barnowl/barnowl/commit/34132f77bccfca7aad71c3e71=
7edfdb1fec5e748
Author: David Benjamin <davidben@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M filterproc.c
M filterproc.h
M functions.c
M message.c
M tester.c
M zcrypt.c
Log Message:
-----------
Rewrite call_filter to use g_spawn_async_with_pipes
This simplifies the error-handling code. Also fixes a bug where file
descriptors get double-closed in call_filter. Also adds a unit test. The
separate prog argument is removed to avoid having to deal with
G_SPAWN_FILE_AND_ARGV_ZERO, and since we don't really use it anyway.
Commit: 6a08f16caa4b11a4d4802c2af4c6de4052fda106
https://github.com/barnowl/barnowl/commit/6a08f16caa4b11a4d4802c2af=
4c6de4052fda106
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M zephyr.c
Log Message:
-----------
zephyr: Add an iterator interface to fields
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Commit: 5b5459562436c2e1f1fa3a0182a7874d8207b55d
https://github.com/barnowl/barnowl/commit/5b5459562436c2e1f1fa3a018=
2a7874d8207b55d
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M functions.c
M perlconfig.c
Log Message:
-----------
zephyr: Use field iterator interface to avoid quadratic loops
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
[davidben@mit.edu: cherry-picked onto release-1.8
Conflicts: functions.c ]
Commit: 54bf6506ad52350d99c21c78c587772e7b3f1316
https://github.com/barnowl/barnowl/commit/54bf6506ad52350d99c21c78c=
587772e7b3f1316
Author: Geoffrey Thomas <geofft@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M global.c
Log Message:
-----------
Remove ^noc from reply-lockout
Given our current user base and how it is no longer primarily people in
MIT's Network group, the danger of having legitimate classes starting
with "noc" overrides the usefulness of having -c noc itself and
affiliated classes in reply-lockout.
This leaves reply-lockout with just class ^mail$. Ideally we'd write an
Athena-specific customization module...
Signed-off-by: Geoffrey Thomas <geofft@mit.edu>
Reviewed-by: David Benjamin <davidben@mit.edu>
Commit: 5044ea93850282a7910286f6cf4e5b6d2254b633
https://github.com/barnowl/barnowl/commit/5044ea93850282a7910286f6c=
f4e5b6d2254b633
Author: Alejandro R. Sede=C3=B1o <asedeno@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M filter.c
Log Message:
-----------
Fix bug generating filter text
Commit: 07cd24d484ade996809976f0d86d9bf15d0e129c
https://github.com/barnowl/barnowl/commit/07cd24d484ade996809976f0d=
86d9bf15d0e129c
Author: Betsy Riley <rileyb@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M commands.c
Log Message:
-----------
Fixed typo in unbindkey Usage error
[davidben@mit.edu: Oh hey, we have one of those in the help text too.
I'll just fix it here.]
Commit: 12a4d6e5432d2180a67aab91cde86790c174e316
https://github.com/barnowl/barnowl/commit/12a4d6e5432d2180a67aab91c=
de86790c174e316
Author: David Benjamin <davidben@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M commands.c
M functions.c
Log Message:
-----------
Don't attempt to switch filters in :view -d if invalid
Add return value to owl_function_create_filter and check before
switching.
Commit: fe569d77cb62257d83a07f9d8546d40fb993682e
https://github.com/barnowl/barnowl/commit/fe569d77cb62257d83a07f9d8=
546d40fb993682e
Author: David Benjamin <davidben@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M functions.c
Log Message:
-----------
Don't leak old_msg in owl_function_zcrypt
Commit: b14838758ba79379265fcf072212007d17e5bacf
https://github.com/barnowl/barnowl/commit/b14838758ba79379265fcf072=
212007d17e5bacf
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M perl/lib/BarnOwl/Style/Default.pm
Log Message:
-----------
Show foreign realms on non-personal zephyrs like Owl did
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: David Benjamin <davidben@mit.edu>
Commit: 91882d6c2409b853fe6ea07c79cb1fb3d25e61f2
https://github.com/barnowl/barnowl/commit/91882d6c2409b853fe6ea07c7=
9cb1fb3d25e61f2
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M perl/lib/BarnOwl/Message/Zephyr.pm
M zephyr.c
Log Message:
-----------
Stop pretending to support zwrite *
=E2=80=98*=E2=80=99 is not a valid recipient, and pretending that it is j=
ust adds more
special cases to get wrong.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: David Benjamin <davidben@mit.edu>
Commit: 3965ec3d4bd4eb3017f6c987fe13dccf4537f460
https://github.com/barnowl/barnowl/commit/3965ec3d4bd4eb3017f6c987f=
e13dccf4537f460
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M message.c
M zephyr.c
M zwrite.c
Log Message:
-----------
Add function to test whether a recipient is personal
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: David Benjamin <davidben@mit.edu>
Commit: 18250fac98343eb21a3d8956ad3958302dfbde30
https://github.com/barnowl/barnowl/commit/18250fac98343eb21a3d8956a=
d3958302dfbde30
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M zwrite.c
Log Message:
-----------
Don=E2=80=99t treat zwrite '' as personal
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: David Benjamin <davidben@mit.edu>
Commit: ef742ad46c5672822dcdb6480fef606c72c744b2
https://github.com/barnowl/barnowl/commit/ef742ad46c5672822dcdb6480=
fef606c72c744b2
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M zwrite.c
Log Message:
-----------
Don=E2=80=99t send public pings on zwrite '' or zwrite @REALM
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: David Benjamin <davidben@mit.edu>
Commit: 16ef9aebca84946c4a9a30dbdf9513f0ab5e987d
https://github.com/barnowl/barnowl/commit/16ef9aebca84946c4a9a30dbd=
f9513f0ab5e987d
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M zwrite.c
Log Message:
-----------
Don=E2=80=99t write CC: line on zwrite -C ''
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: David Benjamin <davidben@mit.edu>
Commit: 1cdb4599bb3665c6194f957b360f5782beb13c1e
https://github.com/barnowl/barnowl/commit/1cdb4599bb3665c6194f957b3=
60f5782beb13c1e
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M functions.c
Log Message:
-----------
Only add outgoing messages for personal part of half-personal messages
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: David Benjamin <davidben@mit.edu>
Commit: 970dafa55df551deff4e8c0e32261d98aca11a28
https://github.com/barnowl/barnowl/commit/970dafa55df551deff4e8c0e3=
2261d98aca11a28
Author: David Benjamin <davidben@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M ChangeLog
M configure.ac
Log Message:
-----------
BarnOwl 1.8.1
Compare: https://github.com/barnowl/barnowl/compare/4f8535e...970dafa=
----==_mimepart_4f60cbd3aa759_47fa3ff698f592f81243ce--
