[3255] in BarnOwl Developers
[barnowl/barnowl] 1f39de: Fix hang on empty zcrypt messages
daemon@ATHENA.MIT.EDU (GitHub)
Wed Mar 14 12:48:20 2012
Date: Wed, 14 Mar 2012 09:48:17 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu
----==_mimepart_4f60cbd1cbf49_46c11cfeae4958e3
Date: Wed, 14 Mar 2012 09:48:17 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <4f60cbd1cd7ef_46c11cfeae495920@sh2.rs.github.com.mail>
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 1f39ded6ba27f83dcf29d7e8434c1f1f996e6a24
https://github.com/barnowl/barnowl/commit/1f39ded6ba27f83dcf29d7e8434c1f1f996e6a24
Author: Alex Dehnert <adehnert@MIT.EDU>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M filterproc.c
Log Message:
-----------
Fix hang on empty zcrypt messages
send_receive will never close wfd if out is an empty string.
Consequently, the zcrypt end will keep waiting for something
to encrypt (or decrypt), thereby deadlocking the barnowl.
This closes wfd if we aren't going to write anything to it.
Consequently, zcrypt will terminate quickly, and we'll also
return.
This fixes a deadlock when sending (at least it's the user's
fault) or receiving (this one is a DoS possibility) empty zcrypted
messages.
Commit: 97cdbaf5d7b6609c5ab134fee3b9c400ae069425
https://github.com/barnowl/barnowl/commit/97cdbaf5d7b6609c5ab134fee3b9c400ae069425
Author: David Benjamin <davidben@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M filterproc.c
M filterproc.h
M functions.c
M message.c
M tester.c
M zcrypt.c
Log Message:
-----------
Rewrite call_filter to use g_spawn_async_with_pipes
This simplifies the error-handling code. Also fixes a bug where file
descriptors get double-closed in call_filter. Also adds a unit test. The
separate prog argument is removed to avoid having to deal with
G_SPAWN_FILE_AND_ARGV_ZERO, and since we don't really use it anyway.
Commit: a03a40927d074512d0f822a48fc294e855aa1c7d
https://github.com/barnowl/barnowl/commit/a03a40927d074512d0f822a48fc294e855aa1c7d
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M zephyr.c
Log Message:
-----------
zephyr: Add an iterator interface to fields
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Commit: d1992076ee837604698514ab3a9755b5ce8bf17a
https://github.com/barnowl/barnowl/commit/d1992076ee837604698514ab3a9755b5ce8bf17a
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2012-03-11 (Sun, 11 Mar 2012)
Changed paths:
M functions.c
M perlconfig.c
Log Message:
-----------
zephyr: Use field iterator interface to avoid quadratic loops
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Compare: https://github.com/barnowl/barnowl/compare/39a531d...d199207
----==_mimepart_4f60cbd1cbf49_46c11cfeae4958e3--
