[3142] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 055e36: Run barnowl-perl-config in locker-build

daemon@ATHENA.MIT.EDU (noreply@github.com)
Sat Jul 16 01:08:17 2011

Date: Fri, 15 Jul 2011 22:08:14 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl

  Commit: 055e366890d6a34efec53d444e951ae1fd402fa0
      https://github.com/barnowl/barnowl/commit/055e366890d6a34efec53d444e951ae1fd402fa0
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M scripts/locker-build

  Log Message:
  -----------
  Run barnowl-perl-config in locker-build

This way we can still run the unit tests.


  Commit: e59d7754bc971383632dff7ab652069cdf7c1cf2
      https://github.com/barnowl/barnowl/commit/e59d7754bc971383632dff7ab652069cdf7c1cf2
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M t/completion.t

  Log Message:
  -----------
  Use the old-style mkpath invocation

Allows the unit tests to run on perl 5.8.


  Commit: 396505be9484248d12ac06a3c67fb1c09d254d32
      https://github.com/barnowl/barnowl/commit/396505be9484248d12ac06a3c67fb1c09d254d32
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M tester.c
  M util.c

  Log Message:
  -----------
  Use owl_global_get_homedir for ~ in owl_util_makepath

It's strange that ~/.zephyr.subs and ~/.owl/startup are computed
differently. We should use the same one. This also matches bash in that
~ prefers $HOME over passwd. If don't have a homedir at all, this
defaults to / instead of keeping the ~, but that won't happen and at
least it's consistent with existing behavior for zephyr dotfiles.


  Commit: 99ac28af43791c8978442bd757de068df2e1b5ff
      https://github.com/barnowl/barnowl/commit/99ac28af43791c8978442bd757de068df2e1b5ff
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M functions.c

  Log Message:
  -----------
  Use GPid instead of pid_t for g_spawn_async's output

Apparently they manage to be different on Solaris. GPid is int while
pid_t is long. Better to cast the value than the pointer.


  Commit: 821937403dc7baff14367b7715f3a349787a4941
      https://github.com/barnowl/barnowl/commit/821937403dc7baff14367b7715f3a349787a4941
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M tester.c
  M util.c

  Log Message:
  -----------
  Use getpwnam_r instead of getpwnam

It's re-entrant, so that's probably a good thing in case some other
thread calls getpwnam. More relevantly, Solaris has both a standard and
a non-standard version, and perl redefines getpwnam to a getpwnam_r. We
manage to convince Solaris to use the standard form, but perl doesn't
seem to notice and defines the macro wrong.

So just avoid the function altogether. Seems as reasonable of an excuse
to use the ostensibly better (and infinitely less friendly) one as any.


  Commit: f5f6ec067fe480f0aed227fce942d421060bc498
      https://github.com/barnowl/barnowl/commit/f5f6ec067fe480f0aed227fce942d421060bc498
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M barnowl
  M runtests.sh

  Log Message:
  -----------
  Don't use export FOO=bar syntax in runtests.sh

Solaris' shell can't run those. We can actually remove the variables
altogether since the tester/barnowl wrapper will take care of it. Also
make the error message in the latter more accurate.


  Commit: 0ba733347e926976295491c03eb975ea1c5e8b75
      https://github.com/barnowl/barnowl/commit/0ba733347e926976295491c03eb975ea1c5e8b75
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M tester.c

  Log Message:
  -----------
  Use g_build_filename to compute reference paths

If the home directory has a trailing slash (for instance, on multics,
root's home is actually '/') then our expected path is wrong.


  Commit: f415f836c9837a0bf2d6ca518b6ddcea47dbfed0
      https://github.com/barnowl/barnowl/commit/f415f836c9837a0bf2d6ca518b6ddcea47dbfed0
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M t/unicode.t

  Log Message:
  -----------
  Don't manually bootstrap BarnOwl in t/unicode.t

We use a custom perl interpreter, so the BarnOwl module has already been
bootstrapped. Silences warnings on older versions of perl. Also
explicitly use BarnOwl in the test so we don't rely on it being done for
us.


  Commit: f6ab6ee703220c4fbafada73532fbcdc3454705a
      https://github.com/barnowl/barnowl/commit/f6ab6ee703220c4fbafada73532fbcdc3454705a
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M runtests.sh

  Log Message:
  -----------
  Use env to set HARNESS_PERL in the prove call

Apparently the previous formulation did not work on Solaris.


  Commit: 2770be9951676ab608fc63538d444f4c7cb5b8a5
      https://github.com/barnowl/barnowl/commit/2770be9951676ab608fc63538d444f4c7cb5b8a5
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M aim.c

  Log Message:
  -----------
  Don't remove GPollFDs in a source's finalize

Arguably this was somewhat of a poor move on glib's part, but you trip
over an assert if you remove a poll from a destroyed source. (This is
distinct from an unref; a source gets the destroyed flag when it is
removed from its GMainContext, and it is finalized when it loses all its
references.)

Reported-by: Edward Z. Yang <ezyang@mit.edu>


  Commit: c85575580186bb656ce655826ceccfa0051fe8fa
      https://github.com/barnowl/barnowl/commit/c85575580186bb656ce655826ceccfa0051fe8fa
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M zephyr.c

  Log Message:
  -----------
  Suppress ZERR_INTERNAL from ZSetLocation for pre-3.0 zephyr

If you are subbed to your own login notifications, ZSetLocation will
wait for the wrong notice and return a spurious ZERR_INTERNAL.
Fortunately, from the debian/changelog, this was fixed right near the
boundary between 2.0 and 3.0, so we can suppress it for the old ABI.


  Commit: 5b24dc04b01a018ea379de8155b314c19148a6de
      https://github.com/barnowl/barnowl/commit/5b24dc04b01a018ea379de8155b314c19148a6de
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M README

  Log Message:
  -----------
  Fix up dependencies in README file

Class::Accessor is a dependency of the core code.  Also, most of the
ones listed are Jabber module dependencies, so we may as well list them
as such.

Reported-by: William Throwe <wthrowe@mit.edu>


  Commit: 0de04fa630694fd65eeab35d863253b6ac924c1b
      https://github.com/barnowl/barnowl/commit/0de04fa630694fd65eeab35d863253b6ac924c1b
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  Check for AnyEvent and Glib in configure.ac

They're dependencies of the core perl code now.


  Commit: 9c582323bbfe4d32bfd80623719631db124460ad
      https://github.com/barnowl/barnowl/commit/9c582323bbfe4d32bfd80623719631db124460ad
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M README

  Log Message:
  -----------
  Document the dependencies of the Twitter module

Most of the stuff is pulled in by Net::Twitter::Lite, but we also use
HTML::Entities (from HTML-Parser).


  Commit: b7117112ee9d20379a32ee09e7ca4c1a223bef1c
      https://github.com/barnowl/barnowl/commit/b7117112ee9d20379a32ee09e7ca4c1a223bef1c
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M README

  Log Message:
  -----------
  Bundled libraries are in perl/modules now

Reported-by: Edward Z. Yang <ezyang@mit.edu>


Compare: https://github.com/barnowl/barnowl/compare/c6332f5...b711711

home help back first fref pref prev next nref lref last post