[3089] in BarnOwl Developers
Re: [PATCH 2/2] Move log-writing onto a background thread.
daemon@ATHENA.MIT.EDU (Sam Hartman)
Sat May 28 11:21:21 2011
From: Sam Hartman <hartmans@MIT.EDU>
To: Adam Glasgall <glasgall@mit.edu>
Cc: barnowl-dev@mit.edu, Adam Glasgall <adam@crossproduct.net>
Date: Sat, 28 May 2011 11:21:15 -0400
In-Reply-To: <1306523507-13379-3-git-send-email-glasgall@mit.edu> (Adam
Glasgall's message of "Fri, 27 May 2011 15:11:47 -0400")
+ endwin();
+ fprintf(stderr, "Error spawning logging thread: %s\n", error->message);
+ fflush(stderr);
+ printf("Error spawning logging thread: %s\n", error->message);
+ fflush(stdout);
+ exit(1);
+ }
Why do you print the error to both stdout and stderr? Besides that the
patch looks generally good although I have not gone through it
line-by-line.
