[3060] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 3b8a56: Remove NULL checks before calling g_free

daemon@ATHENA.MIT.EDU (noreply@github.com)
Fri May 20 16:01:31 2011

Date: Fri, 20 May 2011 13:01:29 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

Branch: refs/heads/master
Home:   https://github.com/barnowl/barnowl

Commit: 3b8a563ae4e07b1064fe005714793565ac720dc4
    https://github.com/barnowl/barnowl/commit/3b8a563ae4e07b1064fe005714793565ac720dc4
Author: David Benjamin <davidben@mit.edu>
Date:   2011-05-20 (Fri, 20 May 2011)

Changed paths:
  M cmd.c
  M commands.c
  M editwin.c
  M functions.c
  M global.c
  M keybinding.c
  M owl.c
  M perlconfig.c
  M perlglue.xs
  M variable.c
  M view.c
  M zcrypt.c
  M zephyr.c
  M zwrite.c

Log Message:
-----------
Remove NULL checks before calling g_free

g_free handles the NULL check for us.


Commit: fda61d3fe64381f30e32bc0091ab5ab59d95524f
    https://github.com/barnowl/barnowl/commit/fda61d3fe64381f30e32bc0091ab5ab59d95524f
Author: David Benjamin <davidben@mit.edu>
Date:   2011-05-20 (Fri, 20 May 2011)

Changed paths:
  M dict.c
  M keymap.c
  M list.c

Log Message:
-----------
g_strdup and g_new0 never fail

Remove pointless failure checks cluttering the code.


Commit: 351c535f7dc84d00617d0fb2c2aa84db44ef9290
    https://github.com/barnowl/barnowl/commit/351c535f7dc84d00617d0fb2c2aa84db44ef9290
Author: David Benjamin <davidben@mit.edu>
Date:   2011-05-20 (Fri, 20 May 2011)

Changed paths:
  M dict.c
  M global.c
  M tester.c

Log Message:
-----------
owl_dict_get_keys never fails

No sense in returning an error code.


Commit: 4c7c21f786a0416a755645b78db0b851f75f8748
    https://github.com/barnowl/barnowl/commit/4c7c21f786a0416a755645b78db0b851f75f8748
Author: David Benjamin <davidben@mit.edu>
Date:   2011-05-20 (Fri, 20 May 2011)

Changed paths:
  M cmd.c
  M dict.c
  M keymap.c
  M tester.c
  M variable.c

Log Message:
-----------
owl_dict_create also never fails

And like everywhere else, we weren't checking the return values most of
the time anyway.


Compare: https://github.com/barnowl/barnowl/compare/7865479...4c7c21f

home help back first fref pref prev next nref lref last post