[3030] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 9efa5b: Clamp the number of color pairs to 256 without ext...

daemon@ATHENA.MIT.EDU (noreply@github.com)
Tue May 3 22:07:38 2011

Date: Tue, 3 May 2011 19:07:33 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

Branch: refs/heads/master
Home:   https://github.com/barnowl/barnowl

Commit: 9efa5bd38b986cf116a08ae43aa3f8629dcc6e60
    https://github.com/barnowl/barnowl/commit/9efa5bd38b986cf116a08ae43aa3f8629dcc6e60
Author: David Benjamin <davidben@mit.edu>
Date:   2011-05-01 (Sun, 01 May 2011)

Changed paths:
  M fmtext.c
  M functions.c
  M global.c
  M owl.c
  M owl.h
  M util.c

Log Message:
-----------
Clamp the number of color pairs to 256 without ext-color

Debian doesn't build their ncurses with ext-color support, so it only
supports 256 colorpairs. However, ncurses still reports the full 32768
value, and color pairs end up trampling over each other.

When 256 is exceeded, the existing colorpair reset logic will now kick
in and fix things. Reword a comment accordingly.

While I'm here, get rid of the colorpairs member in owl_global. ncurses'
works just fine.

Reported-by: Mats Ahlgren <mats_a@mit.edu>


Commit: 7b4f3bea704ed82f2c36ba19fcf354d7442a5bb7
    https://github.com/barnowl/barnowl/commit/7b4f3bea704ed82f2c36ba19fcf354d7442a5bb7
Author: David Benjamin <davidben@mit.edu>
Date:   2011-05-01 (Sun, 01 May 2011)

Changed paths:
  M fmtext.c
  M functions.c
  M global.c
  M owl.h

Log Message:
-----------
Punt owl_global_hascolors

There's not much point as we're hardly abstracting ncurses away. Either
call has_colors directly or just don't bother and let another layer take
care of it.


Compare: https://github.com/barnowl/barnowl/compare/4fd211f...7b4f3be

home help back first fref pref prev next nref lref last post