[3022] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 6a7111: Use g_strjoinv in owl_cmddict_execute_argv, don't ...

daemon@ATHENA.MIT.EDU (noreply@github.com)
Mon Mar 28 17:45:55 2011

Date: Mon, 28 Mar 2011 14:45:53 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

Branch: refs/heads/master
Home:   https://github.com/barnowl/barnowl

Commit: 6a7111370ea0e1de2c3eb86a85f34cd68848d4b1
    https://github.com/barnowl/barnowl/commit/6a7111370ea0e1de2c3eb86a85f34cd68848d4b1
Author: David Benjamin <davidben@mit.edu>
Date:   2011-03-28 (Mon, 28 Mar 2011)

Changed paths:
  M cmd.c
  M perlglue.xs

Log Message:
-----------
Use g_strjoinv in owl_cmddict_execute_argv, don't quote correctly

This reverts commit e3c8332fa85642544dba1222912b77cf6e32ce8c and uses
g_strjoinv instead. The correctly quoted form caused the j keybinding in
BarnOwl::Jabber to break. Without it, the world isn't sane this way
either:

  :perl BarnOwl::bindkey(recv => 'C-f C-f' => command => 'recv:next')

But a solution to this will probably be far more complex and bear little
relation to this commit. In the meantime master really shouldn't have
this obnoxious of a regression on it.



home help back first fref pref prev next nref lref last post