[3015] in BarnOwl Developers
Re: Realms and outgoing messages
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Thu Mar 24 19:46:23 2011
Date: Thu, 24 Mar 2011 19:46:20 -0400 (EDT)
From: Anders Kaseorg <andersk@MIT.EDU>
To: David A Benjamin <davidben@mit.edu>
cc: barnowl-dev@mit.edu
In-Reply-To: <alpine.DEB.1.10.1103241613500.25741@dr-wily.mit.edu>
On Thu, 24 Mar 2011, David A Benjamin wrote:
> Pushed a new version of the branch to my github. Also added a new commit=
=20
> on top to fix a problem I noticed.
> [=E2=80=A6]
> On Thu, 24 Mar 2011, Anders Kaseorg wrote:
> > + /* TODO: We should maybe munge this into the case above, as that c=
omparison
> > + * is a little overly clever. It's also not clear this codepath ev=
er runs
> > + * anyway. */
> >=20
> > It runs if owl_zwrite_get_numrecips(z) =3D=3D 0 in
> > owl_function_add_outgoing_zephyrs, right?
Having investigated this more, I=E2=80=99ve decided I agree that it=E2=80=
=99s not clear=20
whether the codepath ever runs. My conclusion, however, is that it=20
doesn=E2=80=99t, since owl_function_add_outgoing_zephyrs is only called on=
=20
personal zephyrs.
LGTM.
Anders
