[3010] in BarnOwl Developers
[barnowl/barnowl] e56303: Replace owl_parse_delete with g_strfreev
daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Mar 24 17:23:14 2011
Date: Thu, 24 Mar 2011 14:23:12 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: e56303f7b60f05cc30e74453b06725fc031e9384
https://github.com/barnowl/barnowl/commit/e56303f7b60f05cc30e74453b06725fc031e9384
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-24 (Thu, 24 Mar 2011)
Changed paths:
M cmd.c
M filter.c
M tester.c
M util.c
M zwrite.c
Log Message:
-----------
Replace owl_parse_delete with g_strfreev
Also cut the pointless g_strdup in owl_cmddict_execute and allow argc to
be NULL if we don't care about the value.
Commit: f25df21f6284aedd48c098bc68cee9896da5ce98
https://github.com/barnowl/barnowl/commit/f25df21f6284aedd48c098bc68cee9896da5ce98
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-24 (Thu, 24 Mar 2011)
Changed paths:
M cmd.c
M dict.c
M functions.c
M global.c
M help.c
M keymap.c
M perlconfig.c
M perlglue.xs
M tester.c
M variable.c
Log Message:
-----------
Don't call owl_list_create in owl_dict_get_keys
Until we get rid of this owl_list thing altogether, there should be a
convention as to who initializes the thing. Otherwise, we leak memory
from people initializing it too many times.
Whoever reviews this probably wants to look over this very carefully in
case I missed one of the owl_list_creates.
Also kill the various wrappers over owl_list_cleanup as they are not the
inverse of any operation.
Commit: c809f5e8a3cc2745724f518c89b09279b5508b02
https://github.com/barnowl/barnowl/commit/c809f5e8a3cc2745724f518c89b09279b5508b02
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-24 (Thu, 24 Mar 2011)
Changed paths:
M commands.c
M functions.c
M owl.c
Log Message:
-----------
Use owl_function_command_norv when we don't care about the result
Otherwise, we forget to g_free it.
Commit: b13daa044424aacd578ea4f6bf327517d5e7a553
https://github.com/barnowl/barnowl/commit/b13daa044424aacd578ea4f6bf327517d5e7a553
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-24 (Thu, 24 Mar 2011)
Changed paths:
M keybinding.c
M keymap.c
M owl.h
Log Message:
-----------
Make owl_keybinding new/delete instead of init/cleanup
Valgrind is deeply disappointed in this code...
Hide owl_keybinding_make_keys again, so we don't construct half-baked
owl_keybinding instances. Instead allow for creating a dummy keybinding.
Also, initialize all fields of owl_keybinding, or freeing it afterwards
explodes. Also fix a memory leak in unbindkey.
Commit: 45e2c957b8def5f6b03d255c6d1b4dbe94ec5902
https://github.com/barnowl/barnowl/commit/45e2c957b8def5f6b03d255c6d1b4dbe94ec5902
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-24 (Thu, 24 Mar 2011)
Changed paths:
M keybinding.c
M keymap.c
Log Message:
-----------
Don't pass limited buffer lengths to owl_keybinding_tostring
The keymap tostring code still probably should be cleaned up though.
Commit: d07af84683f667d7c34814c1b0a12823b08f6df0
https://github.com/barnowl/barnowl/commit/d07af84683f667d7c34814c1b0a12823b08f6df0
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-24 (Thu, 24 Mar 2011)
Changed paths:
M keybinding.c
M keypress.c
Log Message:
-----------
Clean up owl_keypress_tostring to return a newly-allocated string
I don't think it's possible to overflow the function's internal buffer,
but we may as well avoid this sketchiness.
Commit: 47e0a6a50d1c08ec05030b2507b3f1a84b618a9f
https://github.com/barnowl/barnowl/commit/47e0a6a50d1c08ec05030b2507b3f1a84b618a9f
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-24 (Thu, 24 Mar 2011)
Changed paths:
M editwin.c
M global.c
M keymap.c
M popexec.c
Log Message:
-----------
Punt a number of g_new NULL checks, various minor cleanups
No real need to check g_new's return value as it always succeeds. (Or
destroys the universe^Wprocess in embarrassment.) Also make owl_global
manage the lifetime of the kill buffer since it's part of owl_global
now. And replace a g_new/strncpy with a g_strndup. It's shorter.
Commit: 283ff1e64b51f85106ca81c14d56df397f503009
https://github.com/barnowl/barnowl/commit/283ff1e64b51f85106ca81c14d56df397f503009
Author: David Benjamin <davidben@mit.edu>
Date: 2011-03-24 (Thu, 24 Mar 2011)
Changed paths:
M owl.h
Log Message:
-----------
Punt buffercbdata
It has never been used in the history of this project.
Compare: https://github.com/barnowl/barnowl/compare/42ee1be...283ff1e
